Skip to content

Conversation

@NonStatic2014
Copy link
Contributor

No description provided.

@NonStatic2014 NonStatic2014 requested a review from a team as a code owner December 4, 2018 19:31
Copy link
Contributor

@pranavsharma pranavsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor stuff

BUILD.md Outdated
to build in ACR-Build (Azure Container Registry), you may want to split it to two files and run them one by one.
If you run this Dockerfile directly in ACR-Build, it is likely to hit their timeout limitation (8 hours).

Please see [ARM docker file](dockerfiles/Dockerfile.arm32v7). Docker build run on a Raspberry Pi 3B with Raspbian Stretch Lite OS (Desktop version will run out memory when linking the .so file) will take 8-9 hours in total. If you want to use [Azure Container Registry Tasks](https://docs.microsoft.com/en-us/azure/container-registry/container-registry-tasks-overview) building the Docker image in cloud, you may want to split this Dockerfile to two steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building the Docker image -> to build the Docker image.

Copy link
Contributor

@pranavsharma pranavsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments

pranavsharma
pranavsharma previously approved these changes Dec 4, 2018
@NonStatic2014
Copy link
Contributor Author

Is there a way to trigger the CI pipeline again? The failure should not related to this change.

linkerzhang and others added 3 commits December 4, 2018 13:25
* rename graph.h to graph_viewer.h

* rename graph_base.h to graph.h
* Imlpement StringNormalizer
  Add mixed language tests, test case insentive path.
* Create a locale on the fly. Default locale does not seem to create well.
* Add CI language-pack-en to make default locale available.
  Catch and translate locale creation exception to make the message
  meaningful.
* Make sure locales are configured on Ubuntu.
@pranavsharma
Copy link
Contributor

Is there a way to trigger the CI pipeline again? The failure should not related to this change.

done

Raymond Yang and others added 2 commits December 4, 2018 15:01
* Split the CI pipelines

* Update build bdge display table in README
Revert "Simpler unused parameter in #if defined() switch."
This reverts commit 6b00e6b.

Revert "Better opemmp parallel group count calculation in Softmax parallel running."
This reverts commit c530064.

Revert "Optimize softmax cpu by parallel using openmp."
This reverts commit e7bdfa0.
@NonStatic2014
Copy link
Contributor Author

Some pipeline still waiting..... Could someone take a look? Thanks!

@pranavsharma
Copy link
Contributor

Some pipeline still waiting..... Could someone take a look? Thanks!

queued another build.

@pranavsharma
Copy link
Contributor

We're making some build pipeline changes. Can you please rebase with the master? Thanks.

@pranavsharma pranavsharma merged commit eeb862a into microsoft:master Dec 5, 2018
TedThemistokleous added a commit to TedThemistokleous/onnxruntime that referenced this pull request Jun 2, 2025
quic-ankus pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Nov 25, 2025
* Add build_and_test.py task to run WoS tests in QDC.
* Enable WoS tests in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants