-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Update Dockerfile for ARM build and the build instruction #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pranavsharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor stuff
BUILD.md
Outdated
| to build in ACR-Build (Azure Container Registry), you may want to split it to two files and run them one by one. | ||
| If you run this Dockerfile directly in ACR-Build, it is likely to hit their timeout limitation (8 hours). | ||
|
|
||
| Please see [ARM docker file](dockerfiles/Dockerfile.arm32v7). Docker build run on a Raspberry Pi 3B with Raspbian Stretch Lite OS (Desktop version will run out memory when linking the .so file) will take 8-9 hours in total. If you want to use [Azure Container Registry Tasks](https://docs.microsoft.com/en-us/azure/container-registry/container-registry-tasks-overview) building the Docker image in cloud, you may want to split this Dockerfile to two steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
building the Docker image -> to build the Docker image.
pranavsharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor comments
|
Is there a way to trigger the CI pipeline again? The failure should not related to this change. |
* rename graph.h to graph_viewer.h * rename graph_base.h to graph.h
* Imlpement StringNormalizer Add mixed language tests, test case insentive path. * Create a locale on the fly. Default locale does not seem to create well. * Add CI language-pack-en to make default locale available. Catch and translate locale creation exception to make the message meaningful. * Make sure locales are configured on Ubuntu.
done |
* Split the CI pipelines * Update build bdge display table in README
|
Some pipeline still waiting..... Could someone take a look? Thanks! |
queued another build. |
|
We're making some build pipeline changes. Can you please rebase with the master? Thanks. |
* Add build_and_test.py task to run WoS tests in QDC. * Enable WoS tests in CI
No description provided.