Skip to content

Enable type reduction for Gather CPU kernel. #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skottmckay merged 9 commits into from
Feb 5, 2021
Merged

Enable type reduction for Gather CPU kernel. #6579

skottmckay merged 9 commits into from
Feb 5, 2021

Conversation

@edgchen1
Copy link
Contributor

@edgchen1 edgchen1 commented Feb 5, 2021

Description
Enable type reduction for Gather CPU kernel.

Motivation and Context
Allows implementation to be excluded from binary if the type is not enabled.

@edgchen1 edgchen1 requested a review from skottmckay February 5, 2021 00:57
@edgchen1 edgchen1 requested a review from a team as a code owner February 5, 2021 00:57
edgchen1
edgchen1 commented Feb 5, 2021
View reviewed changes
onnxruntime/core/providers/op_kernel_type_control_utils.h
@@ -0,0 +1,50 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Contributor Author

@edgchen1 edgchen1 Feb 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from #6547
will merge after that PR is merged #Resolved

@skottmckay
Copy link
Contributor

skottmckay commented Feb 5, 2021 •
edited by edgchen1
Loading

}

nit: message should probably say 'not supported in this build' as we support both index types that are valid according to the Gather spec. #Resolved

Refers to: onnxruntime/core/providers/cpu/tensor/gather.cc:159 in 63f1fb2. [](commit_id = 63f1fb2, deletion_comment = False)

skottmckay
skottmckay previously approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@skottmckay skottmckay merged commit 3b376da into master Feb 5, 2021
@skottmckay skottmckay deleted the edgchen1/gather_type_reduction branch February 5, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skottmckay skottmckay skottmckay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgchen1 @skottmckay