Add type reduction support to Slice and Transpose #6547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

skottmckay merged 4 commits into master from skottmckay/TypeReductionSupportForSliceAndTranspose

Feb 5, 2021

Contributor

skottmckay commented Feb 3, 2021

Description:
Add type reduction support to Slice and Transpose kernels.

Motivation and Context
Reduce binary size.


          Add type reduction support to Slice and Transpose

b0f2a07

skottmckay requested a review from a team as a code owner

February 3, 2021 08:31

skottmckay requested a review from edgchen1

February 3, 2021 10:37

Member

yuslepukhin commented Feb 3, 2021

// Licensed under the MIT License.

Does not seem to contain any changes

Refers to: include/onnxruntime/core/framework/data_types_internal.h:2 in b0f2a07. [](commit_id = b0f2a07, deletion_comment = False)

Member

yuslepukhin commented Feb 3, 2021

Provides a type list of enabled types via the 'types' data member.

type member?

Refers to: onnxruntime/core/providers/op_kernel_type_control.h:72 in b0f2a07. [](commit_id = b0f2a07, deletion_comment = False)

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control.h Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control.h Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/cpu/tensor/slice.cc Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control.h Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/cpu/tensor/slice.cc Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/cpu/tensor/transpose.cc Outdated Show resolved Hide resolved

yuslepukhin reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control.h Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/cpu/tensor/slice.cc

    
              }

              template <typename EnabledTypes, typename T>

              static inline bool CallSliceImplIfEnabled(OpKernelContext* ctx,

Contributor

edgchen1 Feb 3, 2021 •

edited

Loading

CallSliceImplIfEnabled [](start = 19, length = 22)

wonder if this can be extended to call arbitrary enable-able code with a lambda... #Closed

Contributor Author

skottmckay Feb 3, 2021

generic lambdas were c++14 and we're currently stuck at c++11, so I didn't think doing it as a lambda was possible.

In reply to: 569695618 [](ancestors = 569695618)

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control.h Outdated Show resolved Hide resolved

Contributor Author

skottmckay commented Feb 3, 2021

// Licensed under the MIT License.

clang-format fixed some whitespace

In reply to: 772659031 [](ancestors = 772659031)

Refers to: include/onnxruntime/core/framework/data_types_internal.h:2 in b0f2a07. [](commit_id = b0f2a07, deletion_comment = False)


          Address PR comments

b4f5d17

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control.h Outdated Show resolved Hide resolved


          Address more PR comments

12d8f19

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control.h Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/providers/op_kernel_type_control_utils.h Outdated Show resolved Hide resolved


          Address PR comments

4ab255a

edgchen1 approved these changes

View reviewed changes

Contributor

edgchen1 left a comment

edgchen1 mentioned this pull request

Enable type reduction for Gather CPU kernel. #6579

Merged

skottmckay merged commit c49d1db into master

skottmckay deleted the skottmckay/TypeReductionSupportForSliceAndTranspose branch

February 5, 2021 01:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet