Fix Android CI build: check return values in ep_compatibility_test.cc #27032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add return value checks for GetAllocatorWithDefaultOptions calls (6 instances) - Add return value check for AllocatorFree call (1 instance) - These functions return OrtStatus* which must be checked due to warn_unused_result attribute - Addresses all 7 compilation errors causing Android CI Pipeline failure Co-authored-by: adrastogi <8368026+adrastogi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow for Android CI Pipeline
Fix Android CI build: check return values in ep_compatibility_test.cc
Jan 16, 2026
adrastogi
merged commit 355082b
into
adrastogi/compat-metadata-api
9 of 10 checks passed
edgchen1
reviewed
Jan 16, 2026
|
|
||
| OrtAllocator* allocator = nullptr; | ||
| api->GetAllocatorWithDefaultOptions(&allocator); | ||
| ASSERT_EQ(api->GetAllocatorWithDefaultOptions(&allocator), nullptr); |
Contributor
There was a problem hiding this comment.
in general, the returned OrtStatus* should be released with ReleaseStatus() if it is not nullptr. the other code in this test does that.
Contributor
There was a problem hiding this comment.
Thanks! Will patch in the parent branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android CI failed due to
-Werror,-Wunused-resulttreating ignored return values as errors. Fixed 7 instances inep_compatibility_test.ccwhere C API functions marked withwarn_unused_resultwere called without checking theirOrtStatus*returns:GetAllocatorWithDefaultOptionsAllocatorFreeChanged from:
To:
Motivation and Context
The Android build uses Clang with strict warnings. These C API functions return
OrtStatus*to indicate success/failure, and ignoring them violates thewarn_unused_resultattribute. The fix follows the pattern used in other test files (e.g.,test_inference.cc) and improves test robustness by catching API errors.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.