Skip to content

[VitisAI] Remove 4k alignment from preferred allocator #25447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HectorSVC merged 4 commits into from
Jul 21, 2025
Merged

[VitisAI] Remove 4k alignment from preferred allocator #25447

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba40f88
VitisAI: removed 4k alignment from preferred allocator
VishalX Jul 18, 2025
831d3da
VitisAI: Fix lint
VishalX Jul 18, 2025
d8ad2b6
VitisAI: Use arena allocator with no 4k alignment
VishalX Jul 21, 2025
60bf1c2
VitisAI: add descriptive naming for local vars
VishalX Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions onnxruntime/core/providers/vitisai/vitisai_execution_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ VitisAIExecutionProvider::VitisAIExecutionProvider(
const ProviderOptions& info)
: IExecutionProvider{onnxruntime::kVitisAIExecutionProvider,
OrtDevice(OrtDevice::CPU, OrtDevice::MemType::DEFAULT, OrtDevice::VendorIds::NONE,
DEFAULT_CPU_ALLOCATOR_DEVICE_ID,
kAlloc4KAlignment)},
info_(info) {
DEFAULT_CPU_ALLOCATOR_DEVICE_ID)},
info_(info) { // Removed 4k alignment for now, need better fix
auto it = info_.find("ep_context_enable");
ep_ctx_enabled_ = it != info_.end() && it->second == "1";
it = info_.find("ep_context_embed_mode");
Expand Down Expand Up @@ -148,20 +147,21 @@ std::unique_ptr<profiling::EpProfiler> VitisAIExecutionProvider::GetProfiler() {

std::vector<AllocatorPtr> VitisAIExecutionProvider::CreatePreferredAllocators() {
std::vector<AllocatorPtr> result;
// We do not want arena for this, as it would not respect alignment.
constexpr const bool use_arena_false = false;
AllocatorCreationInfo device_info_cpu_aligned_4k{
// We do not want arena for 4k alignment, as it would not respect alignment.
// For CPU, use arena
// Removed 4k alignment for now, need better fix
constexpr const bool use_arena_true = true;
AllocatorCreationInfo device_info_cpu{
[](OrtDevice::DeviceId device_id) {
return std::make_unique<CPUAllocator>(
OrtMemoryInfo(
onnxruntime::CPU_ALIGNED_4K, OrtAllocatorType::OrtDeviceAllocator,
onnxruntime::CPU, OrtAllocatorType::OrtDeviceAllocator,
OrtDevice(OrtDevice::CPU, OrtDevice::MemType::DEFAULT, OrtDevice::VendorIds::NONE,
Comment thread
VishalX marked this conversation as resolved.
device_id,
kAlloc4KAlignment)));
device_id)));
},
DEFAULT_CPU_ALLOCATOR_DEVICE_ID, use_arena_false};
DEFAULT_CPU_ALLOCATOR_DEVICE_ID, use_arena_true};

result.push_back(CreateAllocator(device_info_cpu_aligned_4k));
result.push_back(CreateAllocator(device_info_cpu));
return result;
}

Expand Down
Loading