[VitisAI] Remove 4k alignment from preferred allocator #25447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows x64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes 4K memory alignment requirements from the VitisAI execution provider as a temporary fix for IO binding issues with the update_inplace method of OrtValue in ORT 1.23.
- Removes
kAlloc4KAlignmentparameter from OrtDevice constructor in the execution provider initialization - Removes
kAlloc4KAlignmentparameter from OrtDevice constructor in the preferred allocators creation method
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows x64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
VishalX
force-pushed
the
vitisai/alloc-4kalign-fix-iobind
branch
2 times, most recently
from
6de0401 to
d8ad2b6
Compare
yuslepukhin
reviewed
Jul 21, 2025
onnxruntime/core/providers/vitisai/vitisai_execution_provider.cc
Outdated
Show resolved
Hide resolved
- Short term solution for IO binding issue with update_inplace method of OrtValue
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows x64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Aug 8, 2025
Short term solution for IO binding issue with `update_inplace` method of `OrtValue`. ### Description With ORT 1.23 (main), there seem to be an issue with IOBind feature with 4k aligned preferred allocator. Remove the 4k alignment requirement for now for a temp fix. ### Motivation and Context - Fixes issues with IO Binding for few critical models. - Will bring back 4k alignment when we have a appropriate fix in.
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
Short term solution for IO binding issue with `update_inplace` method of `OrtValue`. ### Description With ORT 1.23 (main), there seem to be an issue with IOBind feature with 4k aligned preferred allocator. Remove the 4k alignment requirement for now for a temp fix. ### Motivation and Context - Fixes issues with IO Binding for few critical models. - Will bring back 4k alignment when we have a appropriate fix in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short term solution for IO binding issue with
update_inplacemethod ofOrtValue.Description
With ORT 1.23 (main), there seem to be an issue with IOBind feature with 4k aligned preferred allocator.
Remove the 4k alignment requirement for now for a temp fix.
Motivation and Context