Abbreviate ONNXRuntime as Ort in all of our public APIs #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
'Ort' :-) |
| virtual MLDataType GetElementType() const { | ||
| // should never reach here. | ||
| ONNXRUNTIME_NOT_IMPLEMENTED(__FUNCTION__, " is not implemented"); | ||
| ORT_NOT_IMPLEMENTED(__FUNCTION__, " is not implemented"); |
Contributor
There was a problem hiding this comment.
yeah, having some macros that have ONNXRUNTIME_ and some ORT_ doesn't look very clean.
Contributor
Author
There was a problem hiding this comment.
Ok, I'll make them all ORT_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current prefix was too long and making the API functions hard to read.
This changes to the simple prefix 'Ort' for 'Onnx RunTime' and uses it for all macros and function names in the public headers. This doesn't replace all occurrences of OnnxRuntime\ONNXRuntime\ONNXRUNTIME_ in the code. That can be done next if this change is approved.