Kezhan/partition logic update #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o kezhan/partition_logic_update
… were assigned 2) avoid resolving graph after each provider capability checking and assignment.
snnn
suggested changes
Dec 17, 2018
snnn
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current partitioning logic (greedy) has two potential problems:
Though this may be solved by fusing nodes and adding edges manually in fusing logic, however, to support that, more APIs in graph are needed, as, a) API to get nodes given output node args, 2) API to get nodes given input node args. In this way, I'd suggest to keep using graph resolving here right now and see the perf impact.