Skip to content

Revert removal of eps_without_if_support #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunal-vaishnavi merged 2 commits into from
Nov 17, 2025
Merged

Revert removal of eps_without_if_support #1878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ef9137
add eps_without_if_support
xiaofeihan1 Nov 17, 2025
aa247af
comments
xiaofeihan1 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/python/py/models/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,9 +1589,14 @@ def make_rotary_embedding_multi_cache(self, **kwargs):
self.rope_attrs["save_caches"] = False
cos_cache_small, sin_cache_small = self.make_rotary_embedding_caches(cos_cache_name=cos_cache_small_name, sin_cache_name=sin_cache_small_name)

if self.ep == "dml":
# Concat small and large cos/sin caches for DML EP
# DML EP doesn't support the If operator
# Determine which EPs don't support the If operator
self.eps_without_if_support = ["dml"]
if self.extra_options.get("enable_webgpu_graph", False):
self.eps_without_if_support.append("webgpu")

if self.ep in self.eps_without_if_support:
# Concat small and large cos/sin caches for DML and WebGPU (when graph enabled) EPs
# These EPs don't support the If operator
cos_cache = torch.cat((cos_cache_small, cos_cache_large), dim=0)
sin_cache = torch.cat((sin_cache_small, sin_cache_large), dim=0)
# Save cos/sin caches to disk
Expand Down
Loading