Revert removal of eps_without_if_support#1878
Merged
Merged
Conversation
kunal-vaishnavi
approved these changes
Nov 17, 2025
kunal-vaishnavi
pushed a commit
that referenced
this pull request
Nov 18, 2025
Previously, we incorrectly remove `eps_without_if_support` but actually
we still use it in code as following. So add it back.
```
def make_position_ids_reformatting(self):
if self.ep not in self.eps_without_if_support:
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we incorrectly remove
eps_without_if_supportbut actually we still use it in code as following. So add it back.