Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@chkeita
Copy link
Contributor

@chkeita chkeita commented Feb 16, 2023

Summary of the Pull Request

  • Adds an extra readonly container to all tasks
  • The container will be synced by the agent, same as the setup_dir
  • Adds a new variable substitution to reference it
  • Updates the documentation to add the new {extra} variable substitution
  • Updated some of the integration test to reference the extra container. The content is ignored but it allows us to test the variable substitution.

closes #2827

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #2847 (a271dcc) into main (6cd53b1) will decrease coverage by 0.10%.
The diff coverage is 14.70%.

@@            Coverage Diff             @@
##             main    #2847      +/-   ##
==========================================
- Coverage   28.13%   28.04%   -0.10%     
==========================================
  Files         302      302              
  Lines       35577    35801     +224     
==========================================
+ Hits        10011    10041      +30     
- Misses      25566    25760     +194     
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)
src/ApiService/ApiService/OneFuzzTypes/Model.cs 69.44% <0.00%> (-0.18%) ⬇️
src/ApiService/ApiService/onefuzzlib/Config.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Defs.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Scheduler.cs 15.16% <0.00%> (-0.27%) ⬇️
src/agent/coverage/src/binary.rs 47.19% <0.00%> (ø)
src/agent/onefuzz-agent/src/debug.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-agent/src/setup.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/local/common.rs 0.00% <0.00%> (ø)
...ent/onefuzz-task/src/local/libfuzzer_test_input.rs 0.00% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

chkeita and others added 18 commits February 15, 2023 18:38
Old failure message:
```
failed to launch extension
```

New failure message:

```
failed to launch extension(s): Errors for extension 'CustomScriptExtension':
:Error: ProvisioningState/failed/3 (Provisioning failed) - Failed to download all specified files. Exiting. Error Message: The remote server returned an error: (400) Bad Request.
```
* Add new command

* Update remaining jinja templates and references to use scriban

* Add ado template validation

* Validate ado and github templates

* Remove unnecessary function

* Update src/ApiService/ApiService/OneFuzzTypes/Model.cs

Co-authored-by: Cheick Keita <[email protected]>

---------

Co-authored-by: Cheick Keita <[email protected]>
@chkeita chkeita requested review from Porges and tevoinea February 21, 2023 17:20
@chkeita chkeita marked this pull request as ready for review February 21, 2023 17:35
@chkeita chkeita changed the title adding extra container to tasks Adding extra container to tasks Feb 21, 2023
@chkeita chkeita enabled auto-merge (squash) February 23, 2023 18:57
@chkeita chkeita merged commit b848968 into microsoft:main Feb 23, 2023
@mgreisen mgreisen mentioned this pull request Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow extra container to be used in tasks

5 participants