Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@mgreisen
Copy link
Contributor

Summary of the Pull Request

The default fabricbot needs triage label was different from what we use.

@codecov-commenter
Copy link

Codecov Report

Merging #2845 (7420a72) into main (2d59a2a) will decrease coverage by 3.14%.
The diff coverage is 17.64%.

@@            Coverage Diff             @@
##             main    #2845      +/-   ##
==========================================
- Coverage   29.84%   26.71%   -3.14%     
==========================================
  Files         324      125     -199     
  Lines       39130    13335   -25795     
==========================================
- Hits        11680     3562    -8118     
+ Misses      27450     9773   -17677     
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)
src/ApiService/ApiService/onefuzzlib/Config.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Defs.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/OneFuzzTypes/Model.cs 70.17% <50.00%> (-0.32%) ⬇️
.../ApiService/ApiService/OneFuzzTypes/ReturnTypes.cs 68.57% <0.00%> (-1.70%) ⬇️
src/agent/onefuzz-task/src/local/common.rs
src/agent/onefuzz-task/src/local/coverage.rs
...c/agent/onefuzz-task/src/tasks/coverage/generic.rs
src/agent/dynamic-library/src/linux/tests.rs
src/agent/onefuzz-agent/src/coordinator.rs
... and 174 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mgreisen mgreisen enabled auto-merge (squash) February 15, 2023 23:45
@mgreisen mgreisen merged commit e0e6981 into main Feb 15, 2023
chkeita pushed a commit to chkeita/onefuzz that referenced this pull request Feb 16, 2023
@mgreisen mgreisen deleted the mgreisen-patch-1 branch February 17, 2023 16:58
chkeita added a commit that referenced this pull request Feb 23, 2023
* adding extra container to tasks

* setup expand

* build fix

* generate docs

* build fix

* build fix

* build fix

* format

* format

* build fix

* fix extra container references

* format

* Update "Needs Triage" label to the one we use. (#2845)

* Report extension errors (#2846)

Old failure message:
```
failed to launch extension
```

New failure message:

```
failed to launch extension(s): Errors for extension 'CustomScriptExtension':
:Error: ProvisioningState/failed/3 (Provisioning failed) - Failed to download all specified files. Exiting. Error Message: The remote server returned an error: (400) Bad Request.
```

* Sematically validate notification configs (#2850)

* Add new command

* Update remaining jinja templates and references to use scriban

* Add ado template validation

* Validate ado and github templates

* Remove unnecessary function

* Update src/ApiService/ApiService/OneFuzzTypes/Model.cs

Co-authored-by: Cheick Keita <[email protected]>

---------

Co-authored-by: Cheick Keita <[email protected]>

* adding extra container to integration tests

* adding doc

* update tests

* format

* build and clippy fix

* Update src/agent/onefuzz-task/src/tasks/report/generic.rs

Co-authored-by: Teo Voinea <[email protected]>

---------

Co-authored-by: Marc Greisen <[email protected]>
Co-authored-by: George Pollard <[email protected]>
Co-authored-by: Teo Voinea <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants