Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade node-gyp to fix macOS build error #673

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: upgrade node-gyp to fix macOS build error #673

merged 1 commit into from
Mar 15, 2024

Conversation

kkocdko
Copy link
Contributor

@kkocdko kkocdko commented Mar 15, 2024 •
edited
Loading

Fix #643

Fix #646

@kkocdko kkocdko changed the title Upgrade node-gyp to fix #643 and #646 fix: Upgrade node-gyp to fix #643 and #646 Mar 15, 2024
@kkocdko kkocdko changed the title fix: Upgrade node-gyp to fix #643 and #646 fix: Upgrade node-gyp to fix macOS build error Mar 15, 2024
@kkocdko
Copy link
Contributor Author

kkocdko commented Mar 15, 2024 •
edited
Loading

@deepak1556 Hi, could you please take the time to merge this, it would be very useful for macOS (and other environment with Python 3.12) users.

And I think #653 is ready to merge also, we already drop ancient io.js supports. Thank you very much!

@kkocdko kkocdko changed the title fix: Upgrade node-gyp to fix macOS build error fix: upgrade node-gyp to fix macOS build error Mar 15, 2024
@kkocdko
Copy link
Contributor Author

kkocdko commented Mar 15, 2024 •
edited
Loading

Not sure why CI APIScan failed .

deepak1556
deepak1556 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VSCodeTriageBot VSCodeTriageBot added this to the March 2024 milestone Mar 15, 2024
@deepak1556
Copy link
Contributor

@sbatten @rzhao271 there is an auth issue with APIScan run, can this be ignored for now ?

ERROR: System.AggregateException: One or more errors occurred. ---> System.TypeInitializationException: The type initializer for 'Microsoft.Tools.ApiScan.ApiScanLib.DataStore.SqlAuthProvider' threw an exception. ---> System.ArgumentException: Connection string $(apiscan-connectionstring) is not in a proper format. Expected format is Key1=Value1;Key2=Value2;

@rzhao271
Copy link
Contributor

The APIScan issue is unrelated. Merging the PR.

@rzhao271 rzhao271 merged commit f25bb55 into microsoft:main Mar 15, 2024
8 of 10 checks passed
@deepak1556
Copy link
Contributor

@rzhao271 is the APIScan auth issue tracked somewhere ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March 2024
Development

Successfully merging this pull request may close these issues.

Upgrade node-gyp to support Python 3.12 OSX failure...
5 participants
@kkocdko @deepak1556 @rzhao271 @bpasero @VSCodeTriageBot