chore: remove deprecated api process.binding
#653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkocdko
changed the title
process.bindingprocess.binding
kkocdko
changed the title
process.bindingprocess.binding
Tyriar
reviewed
Mar 15, 2024
|
Can you rebase on latest main |
Originally designed to work with ancient node.js 0.12 and io.js
deepak1556
approved these changes
Mar 18, 2024
bpasero
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code from pty.js (chjj) was originally designed to work with ancient versions of node.js
0.12and io.js, but the api is DEPRECATED for many years, the/* require("node:tty") */ tty.ReadStreamconsturctor received a pipe fd is just worked (both r/w).Related to #632 .
See nodejs/node#37780 also.