Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cf and spectre flags #533

Merged
merged 9 commits into from
Mar 18, 2022
Merged

add cf and spectre flags #533

merged 9 commits into from
Mar 18, 2022

Conversation

TylerLeonhardt
Copy link
Member

No description provided.

@TylerLeonhardt TylerLeonhardt self-assigned this Mar 1, 2022
@Tyriar
Copy link
Member

Tyriar commented Mar 2, 2022

What's up with this change? We are currently not on the latest version of node-pty due to not resolving issues that arose in vscode when updating to #487

@Tyriar Tyriar added this to the 1.0.0 milestone Mar 2, 2022
deepak1556
deepak1556 reviewed Mar 2, 2022
View reviewed changes
binding.gyp Outdated Show resolved Hide resolved
@deepak1556
Copy link
Contributor

@Tyriar these are part of the fixes to resolve the issues reported by the BinSkim tool

Tyriar
Tyriar reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring approval to @deepak1556

@sbatten sbatten requested a review from deepak1556 March 16, 2022 23:42
deepak1556
deepak1556 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a change to remove redundant declarations. target_defaults will apply to all targets in the file.

deepak1556
deepak1556 reviewed Mar 17, 2022
View reviewed changes
azure-pipelines.yml Outdated
@@ -54,7 +54,7 @@ jobs:

- job: Windows
pool:
vmImage: 'vs2017-win2016'
vmImage: 'windows-latest'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyriar I have moved these from deprecated images.

@deepak1556
Copy link
Contributor

deepak1556 commented Mar 17, 2022 •
edited
Loading

Module tests does not pass with windows-2022 agent https://github.com/microsoft/node-pty/runs/5583465216, this needs further investigation for future agent updates. Reverted to windows-2019 agent.

@TylerLeonhardt
Copy link
Member Author

@deepak1556 think this is good to go and we'll update the agent later?

@deepak1556
Copy link
Contributor

Sorry, yeah this PR is good to go, don't have plans to look into the windows-2022 agent failure for now since vscode core still uses 2019 agent. Happy if others want to tackle it now.

@deepak1556 deepak1556 merged commit 1674722 into main Mar 18, 2022
@deepak1556 deepak1556 deleted the tyler-add-better-flags branch March 18, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@Tyriar Tyriar Tyriar left review comments

@sbatten sbatten sbatten approved these changes

Assignees

@TylerLeonhardt TylerLeonhardt

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TylerLeonhardt @Tyriar @deepak1556 @sbatten