add cf and spectre flags (#533)

* add cf and spectre flags * remove ExceptionHandling * chore: remove duplicate declaration * ci: update pipeline images * chore: update node-gyp * ci: update script execution * Revert "ci: update script execution" This reverts commit b5b6afe. * Revert "chore: update node-gyp" This reverts commit 9ee77a3. * ci: revert to 2019 agent Co-authored-by: deepak1556 <[email protected]>
microsoft · Mar 18, 2022 · 1674722 · 1674722
1 parent a858198
commit 1674722
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -30,7 +30,7 @@ jobs:
 
 - job: macOS
   pool:
-    vmImage: 'macOS-10.15'
+    vmImage: 'macOS-latest'
   strategy:
     matrix:
       node_12_x:
@@ -54,7 +54,7 @@ jobs:
 
 - job: Windows
   pool:
-    vmImage: 'vs2017-win2016'
+    vmImage: 'windows-2019'
   strategy:
     matrix:
       node_12_x:

diff --git a/binding.gyp b/binding.gyp
@@ -1,4 +1,23 @@
 {
+  'target_defaults': {
+    'conditions': [
+      ['OS=="win"', {
+        'msvs_settings': {
+            'VCCLCompilerTool': {
+              'AdditionalOptions': [
+                '/Qspectre',
+                '/guard:cf'
+              ]
+            },
+            'VCLinkerTool': {
+              'AdditionalOptions': [
+                '/guard:cf'
+              ]
+            }
+          },
+      }],
+    ],
+  },
   'conditions': [
     ['OS=="win"', {
       'targets': [
@@ -13,7 +32,7 @@
           ],
           'libraries': [
             'shlwapi.lib'
-          ]
+          ],
         },
         {
           'target_name': 'conpty_console_list',
@@ -22,7 +41,7 @@
           ],
           'sources' : [
             'src/win/conpty_console_list.cc'
-          ]
+          ],
         },
         {
           'target_name': 'pty',