This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix env folder #3472
Merged
SparkSnail
merged 38 commits into
microsoft:master
from
SparkSnail:shinyang/dev-fix-reuse-envfolder
Apr 2, 2021
Merged
Fix env folder #3472
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
dcd2ffd
Merge pull request #251 from microsoft/master
SparkSnail 3b8b6fb
Merge pull request #252 from microsoft/master
SparkSnail 916e444
Merge pull request #253 from microsoft/master
SparkSnail caeffb8
Merge pull request #254 from microsoft/master
SparkSnail 57c300e
Merge pull request #255 from microsoft/master
SparkSnail 65660e6
Merge pull request #257 from microsoft/master
SparkSnail 9376d6a
Merge pull request #258 from microsoft/master
SparkSnail 5fef3cf
Merge pull request #259 from microsoft/master
SparkSnail 5544ae8
Merge pull request #261 from microsoft/master
SparkSnail f9fdfee
Merge pull request #262 from microsoft/master
SparkSnail aa64fe6
Merge pull request #263 from microsoft/master
SparkSnail c6a5f8c
Merge pull request #264 from microsoft/master
SparkSnail 68abe2f
Merge pull request #265 from microsoft/master
SparkSnail 14e9619
Merge pull request #266 from microsoft/master
SparkSnail f69e206
Merge pull request #267 from microsoft/master
SparkSnail 12ef0aa
Merge pull request #270 from microsoft/master
SparkSnail ddcf229
Merge pull request #271 from microsoft/master
SparkSnail c4f6e66
Merge pull request #272 from microsoft/master
SparkSnail 88f8c1b
Merge pull request #273 from microsoft/master
SparkSnail 7eb15f8
Merge pull request #274 from microsoft/master
SparkSnail f73367f
Merge pull request #275 from microsoft/master
SparkSnail 765bc33
Merge pull request #276 from microsoft/master
SparkSnail cff51cc
Merge pull request #277 from microsoft/master
SparkSnail 4232fea
Merge pull request #278 from microsoft/master
SparkSnail cb9efcc
Merge pull request #279 from microsoft/master
SparkSnail ee71f16
Merge pull request #280 from microsoft/master
SparkSnail c3921ed
Merge pull request #281 from microsoft/master
SparkSnail 561f1ad
Merge pull request #284 from microsoft/master
SparkSnail daf028a
Merge pull request #285 from microsoft/master
SparkSnail 9a8a4a3
Merge pull request #286 from microsoft/master
SparkSnail 22a38dd
Merge pull request #287 from microsoft/master
SparkSnail 645e1a6
Merge pull request #288 from microsoft/master
SparkSnail f41c25d
Merge pull request #289 from microsoft/master
SparkSnail 9fb5ff9
Merge pull request #290 from microsoft/master
SparkSnail e3fab14
Merge pull request #291 from microsoft/master
SparkSnail 19f95f0
init
SparkSnail 93a0345
update
SparkSnail 942b196
revert change
SparkSnail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a concern that if users want to find their outputs, they need know the trail's runner. And do we have a place to save these mapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, already add trials' envId and platform information in
nnictl trial ls
and webui.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I find
envId
, but it seems there no place to store therunnerId
, that I need it to splice path likeexpId/envs/runnerId/trials/trialId
. And I am worried if the checkpoint or output is easy to find under this way. Before, I know it is underexpId/trials/trialId
, but now I need a way to getrunnerId
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I find we saved
envName
, but noenvId
, I made a mistake upstairs.