Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix env folder #3472

Merged

Conversation

SparkSnail
Copy link
Contributor

  1. Move trials folder under env/{envId} folder to map trial jobs
  2. Remove remote mode dup env folder

SparkSnail added 30 commits May 29, 2020 17:02
@@ -47,7 +47,7 @@ def run(self):

nni_log(LogType.Info, "%s: start to run trial" % self.name)

trial_working_dir = os.path.realpath(os.path.join(os.curdir, "..", "..", "trials", self.id))
trial_working_dir = os.path.realpath(os.path.join(os.curdir, "trials", self.id))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a concern that if users want to find their outputs, they need know the trail's runner. And do we have a place to save these mapping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, already add trials' envId and platform information in nnictl trial ls and webui.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I find envId, but it seems there no place to store the runnerId, that I need it to splice path like expId/envs/runnerId/trials/trialId. And I am worried if the checkpoint or output is easy to find under this way. Before, I know it is under expId/trials/trialId, but now I need a way to get runnerId.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I find we saved envName, but no envId, I made a mistake upstairs.

@SparkSnail SparkSnail merged commit e85f029 into microsoft:master Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants