-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix env folder #3472
Fix env folder #3472
Conversation
SparkSnail
commented
Mar 23, 2021
- Move trials folder under env/{envId} folder to map trial jobs
- Remove remote mode dup env folder
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
Chinese translation (microsoft#2458)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Merge master
merge master
merge master
merge master
merge master
merge master
nni/tools/trial_tool/trial.py
Outdated
@@ -47,7 +47,7 @@ def run(self): | |||
|
|||
nni_log(LogType.Info, "%s: start to run trial" % self.name) | |||
|
|||
trial_working_dir = os.path.realpath(os.path.join(os.curdir, "..", "..", "trials", self.id)) | |||
trial_working_dir = os.path.realpath(os.path.join(os.curdir, "trials", self.id)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a concern that if users want to find their outputs, they need know the trail's runner. And do we have a place to save these mapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, already add trials' envId and platform information in nnictl trial ls
and webui.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I find envId
, but it seems there no place to store the runnerId
, that I need it to splice path like expId/envs/runnerId/trials/trialId
. And I am worried if the checkpoint or output is easy to find under this way. Before, I know it is under expId/trials/trialId
, but now I need a way to get runnerId
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I find we saved envName
, but no envId
, I made a mistake upstairs.