Skip to content

Conversation

@lilgreenbird
Copy link
Contributor

No description provided.

CHANGELOG.md Outdated

### Fixed Issues
- Fixed slf4j warning message in tests
- Fixed NullPointerException in logException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed potential NullPointerException in logException()

@codecov-io
Copy link

codecov-io commented Oct 29, 2018

Codecov Report

Merging #864 into dev will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #864      +/-   ##
============================================
+ Coverage     48.67%   48.96%   +0.28%     
- Complexity     2793     2821      +28     
============================================
  Files           116      116              
  Lines         27875    27875              
  Branches       4650     4650              
============================================
+ Hits          13569    13648      +79     
- Misses        12099    12102       +3     
+ Partials       2207     2125      -82
Flag Coverage Δ Complexity Δ
#JDBC42 48.46% <ø> (+0.3%) 2777 <ø> (+29) ⬆️
#JDBC43 48.57% <ø> (ø) 2792 <ø> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 43.76% <0%> (-2.19%) 106% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.12% <0%> (-0.21%) 64% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.79% <0%> (ø) 264% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.48% <0%> (+0.19%) 5% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.8% <0%> (+0.28%) 141% <0%> (+6%) ⬆️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.63% <0%> (+0.53%) 349% <0%> (+14%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.79% <0%> (+0.64%) 43% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.96% <0%> (+0.86%) 0% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.06% <0%> (+1.07%) 93% <0%> (+4%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 78.94% <0%> (+1.5%) 33% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f097cd...0a78f0a. Read the comment docs.

CHANGELOG.md Outdated
- Added support for Jacoco in VSTS
- Updated SQL keywrods in DatabaseMetaData
- Enabled non-running junit tests
- Improvements in Database metadata to prevent Statement leaks and enhance Statement caching
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either use Database Metadata or database metadata

CHANGELOG.md Outdated
- Fixed slf4j warning message in tests
- Fixed NullPointerException in logException
- Fixed intermittent junit lobTest failures
- Fixed batch insert in Bulk Copy API to respect timeout value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterbae , is this accurate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a bit wrong. I always make my PR title representative of the change (you can mostly copy-paste the PR title to the changelog, and it'll make sense: #817)

I would change this to "Fixed Bulk Copy API for batch insert to respect the timeout value".

@lilgreenbird lilgreenbird changed the title updates for 7.1.2 updates for 7.1.2 prelease Oct 29, 2018
@lilgreenbird lilgreenbird changed the title updates for 7.1.2 prelease updates for 7.1.2 preview Oct 29, 2018
@cheenamalhotra cheenamalhotra changed the title updates for 7.1.2 preview Updates for 7.1.2 preview release Oct 29, 2018
@lilgreenbird lilgreenbird merged commit b331c3b into microsoft:dev Oct 29, 2018
@lilgreenbird lilgreenbird deleted the release branch November 2, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants