Change Bulk Copy API for batch insert to respect the timeout value#817
Merged
peterbae merged 2 commits intomicrosoft:devfrom Oct 26, 2018
Merged
Change Bulk Copy API for batch insert to respect the timeout value#817peterbae merged 2 commits intomicrosoft:devfrom
peterbae merged 2 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #817 +/- ##
============================================
- Coverage 48.67% 48.59% -0.09%
+ Complexity 2817 2794 -23
============================================
Files 116 116
Lines 27878 27885 +7
Branches 4651 4651
============================================
- Hits 13571 13550 -21
+ Misses 12173 12126 -47
- Partials 2134 2209 +75
Continue to review full report at Codecov.
|
rene-ye
previously approved these changes
Oct 24, 2018
cheenamalhotra
previously approved these changes
Oct 24, 2018
ulvii
approved these changes
Oct 25, 2018
rene-ye
approved these changes
Oct 25, 2018
Contributor
|
Please add tests, for default case and when timeout is set. |
Contributor
Author
|
@ulvii I wanted to write a test as well but that would be difficult. This part of the code is only accessed when the target server is Azure DW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #803
Statements can have timeouts on their query, and currently this isn't being respected by Bulk Copy API for batch insert. This PR fixes that issue.
I've tested this manually and confirmed the queryTimeout value is correctly applied to the Bulk Copy operation.