Fix broken build on Alpine

[ManickaP]

lsb-release is not present on Alpine, whereas os-release is on most distributions.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (d677687) to head (1b43d88).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4264      +/-   ##
==========================================
- Coverage   85.77%   83.51%   -2.27%     
==========================================
  Files          56       56              
  Lines       15382    15382              
==========================================
- Hits        13194    12846     -348     
- Misses       2188     2536     +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ManickaP]

This is still not enough. Since the build kind of assumes Ubuntu as the only distro and enables XDP everywhere except Ubuntu 20.04:

msquic/src/platform/CMakeLists.txt

Line 38 in 5052f34

set(LINUX_XDP_ENABLED TRUE)

Which leads to:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
BPF_LIB
    linked by target "platform" in directory /tmp/msquic/src/platform
NL_LIB
    linked by target "platform" in directory /tmp/msquic/src/platform
NL_ROUTE_LIB
    linked by target "platform" in directory /tmp/msquic/src/platform
XDP_LIB
    linked by target "platform" in directory /tmp/msquic/src/platform

on Alpine.

[ami-GS]

Thanks for the change. As far as I remember, our docker environment doesn't have /etc/os-release. let me double check

[ami-GS]

Exists!😵‍💫

[ManickaP]

I renamed the parameter, updated the pipeline (hopefully in the right place) and removed QUIC_CARGO_BUILD, PTAL.

[nibanks]

Everything looks good to me, but @ami-GS can you please take a look? I noticed netperf failed, but I wonder if this is because of something else being broken? I know you're working on that in a parallel PR.

[nibanks]

What should we do for the Official, OneBranch builds? Enabled or disabled?

[ami-GS]

rerunning BVT xdp test...

[ami-GS]

Could you update Linux XDP documentation? I believe build.ps1 requires additional parameter

https://github.com/microsoft/msquic/blob/main/docs/BUILD.md#linux-xdp

[wfurt]

LGTM

[ManickaP]

BTW, I don't have rights to merge this, so unless there is more feedback to address (let me know if there still something is), feel free to merge on my behalf. And thanks all for help with this!