Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated eslint-plugin-minecraft-linting #38

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Updated eslint-plugin-minecraft-linting #38

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd8e19d
Update to new linter and ensure linting passes
SBLMikeDemone Mar 15, 2024
05851f9
Do null check on players scoreboard identities
SBLMikeDemone Mar 15, 2024
e6c05c6
Update to 1.2.1 to get Raphs changes
SBLMikeDemone Mar 15, 2024
699367d
Merge in main
SBLMikeDemone Mar 28, 2024
cf36386
Update min version
SBLMikeDemone Mar 28, 2024
75b47e7
Remove scoreboardIdentity
SBLMikeDemone Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions build-challenge/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions build-challenge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"devDependencies": {
"@minecraft/core-build-tasks": "^1.1.3",
"eslint-plugin-minecraft-linting": "^1.1.1",
"eslint-plugin-minecraft-linting": "^1.2.0",
"source-map": "^0.7.4",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
Expand Down Expand Up @@ -34,4 +34,4 @@
"@minecraft/server": "$@minecraft/server"
}
}
}
}
8 changes: 4 additions & 4 deletions howto-gallery/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions howto-gallery/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"devDependencies": {
"@minecraft/core-build-tasks": "^1.1.3",
"eslint-plugin-minecraft-linting": "^1.1.1",
"eslint-plugin-minecraft-linting": "^1.2.0",
"source-map": "^0.7.4",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
Expand Down Expand Up @@ -40,4 +40,4 @@
"@minecraft/server": "$@minecraft/server"
}
}
}
}
SBLMikeDemone marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 4 additions & 4 deletions script-box/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions script-box/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"devDependencies": {
"@minecraft/core-build-tasks": "^1.1.3",
"eslint-plugin-minecraft-linting": "^1.1.1",
"eslint-plugin-minecraft-linting": "^1.2.0",
"source-map": "^0.7.4",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
Expand All @@ -30,4 +30,4 @@
"@minecraft/server": "$@minecraft/server"
}
}
}
}
8 changes: 4 additions & 4 deletions ts-starter-complete-cotta/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ts-starter-complete-cotta/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"devDependencies": {
"@minecraft/core-build-tasks": "^1.1.3",
"eslint-plugin-minecraft-linting": "^1.1.1",
"eslint-plugin-minecraft-linting": "^1.2.0",
"source-map": "^0.7.4",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
Expand All @@ -26,4 +26,4 @@
"@minecraft/server-ui": "^1.1.0",
"@minecraft/vanilla-data": "^1.20.60"
}
}
}
15 changes: 13 additions & 2 deletions ts-starter-complete-cotta/scripts/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { world, system, BlockPermutation, EntityInventoryComponent, ItemStack, DisplaySlotId } from "@minecraft/server";
import {
world,
system,
BlockPermutation,
EntityInventoryComponent,
ItemStack,
DisplaySlotId,
ScoreboardIdentity,
SBLMikeDemone marked this conversation as resolved.
Show resolved Hide resolved
} from "@minecraft/server";
import Utilities from "./Utilities.js";

const START_TICK = 100;
Expand Down Expand Up @@ -41,7 +49,10 @@ function initializeBreakTheTerracotta() {
let players = world.getAllPlayers();

for (let player of players) {
player.runCommand("scoreboard players set @s score 0");
if (player.scoreboardIdentity === undefined) {
SBLMikeDemone marked this conversation as resolved.
Show resolved Hide resolved
continue;
}
scoreObjective.setScore(player.scoreboardIdentity, 0);

let inv = player.getComponent("inventory") as EntityInventoryComponent;
inv.container?.addItem(new ItemStack("diamond_sword"));
Expand Down
8 changes: 4 additions & 4 deletions ts-starter/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ts-starter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"devDependencies": {
"@minecraft/core-build-tasks": "^1.1.3",
"eslint-plugin-minecraft-linting": "^1.1.1",
"eslint-plugin-minecraft-linting": "^1.2.0",
"source-map": "^0.7.4",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
Expand All @@ -26,4 +26,4 @@
"@minecraft/server-ui": "^1.1.0",
"@minecraft/vanilla-data": "^1.20.60"
}
}
}