Updated eslint-plugin-minecraft-linting #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBLMikeDemone
commented
Mar 15, 2024
frgarc
approved these changes
Mar 15, 2024
|
Updated to 1.2.1 to get rid of a bunch of dependencies (nearly 1000 lines from each package-lock.json woo!) |
was only the version the issue? 😮 |
@frgarc Ah, no, I should've been more clear. Raph moved a bunch of core build tool dependencies to dev dependencies: Mojang/minecraft-scripting-libraries#22 |
rlandav
approved these changes
Mar 19, 2024
|
@microsoft-github-policy-service agree company="Skybox Labs" |
|
@frgarc After grabbing your changes this PR is significantly smaller! I'm re-requesting a review post merge to make sure I didn't miss anything :) |
frgarc
approved these changes
Mar 28, 2024
SBLMikeDemone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-minecraft-linting was updated to catch a few more potential issues here: Mojang/minecraft-scripting-libraries#21 and this PR updates all the samples and ensures they all pass
npm run lint.Tested by running the ts-starter-complete-cotta and ensuring my score was reset to 0 when restarting.