Skip to content

fix table schema issue and also adding live tests for missing Kusto calls #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2025
Merged

fix table schema issue and also adding live tests for missing Kusto calls #579

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83ae957
fix table schema issue and also adding live tests for missing Kusto c…
prvavill Sep 25, 2025
0db99c2
fix
prvavill Sep 25, 2025
14e3af0
Merge branch 'main' into user/prvavill/table_schema_fix
prvavill Sep 26, 2025
fbbd0ff
updated change log
prvavill Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tools/Azure.Mcp.Tools.Kusto/src/Services/KustoService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,9 @@ public async Task<string> GetTableSchemaAsync(
databaseName,
$".show table {tableName} cslschema", CancellationToken.None);
var result = KustoResultToStringList(kustoResult);
var schema = result.FirstOrDefault();
if (schema is not null)
if (result.Count > 0)
{
return schema;
return string.Join(Environment.NewLine, result);
}
throw new Exception($"No schema found for table '{tableName}' in database '{databaseName}'.");
}
Expand Down
114 changes: 113 additions & 1 deletion tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.LiveTests/KustoCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public class KustoCommandTests(ITestOutputHelper output)
: CommandTestsBase(output)
{
private const string TestDatabaseName = "ToDoLists";
private const string TestTableName = "ToDoList";

#region Init
public override async ValueTask InitializeAsync()
{
await base.InitializeAsync(); // Initialize the base class first
Expand Down Expand Up @@ -50,7 +52,9 @@ public override async ValueTask InitializeAsync()
Assert.Skip("Skipping until auth fixed for Kusto");
}
}
#endregion

#region Databases
[Fact]
public async Task Should_list_databases_in_cluster()
{
Expand All @@ -66,7 +70,9 @@ public async Task Should_list_databases_in_cluster()
Assert.Equal(JsonValueKind.Array, databasesArray.ValueKind);
Assert.NotEmpty(databasesArray.EnumerateArray());
}
#endregion

#region Tables
[Fact]
public async Task Should_list_kusto_tables()
{
Expand All @@ -84,6 +90,83 @@ public async Task Should_list_kusto_tables()
Assert.NotEmpty(tablesArray.EnumerateArray());
}

[Fact]
public async Task Should_list_tables_with_direct_uri()
{
var clusterInfo = await CallToolAsync(
"azmcp_kusto_cluster_get",
new()
{
{ "subscription", Settings.SubscriptionId },
{ "cluster", Settings.ResourceBaseName }
});

var clusterUri = clusterInfo.AssertProperty("cluster").AssertProperty("clusterUri").GetString();
Assert.NotNull(clusterUri);

var result = await CallToolAsync(
"azmcp_kusto_table_list",
new()
{
{ "cluster-uri", clusterUri },
{ "database", TestDatabaseName }
});

var tablesArray = result.AssertProperty("tables");
Assert.Equal(JsonValueKind.Array, tablesArray.ValueKind);
Assert.NotEmpty(tablesArray.EnumerateArray());
}

[Fact]
public async Task Should_get_table_schema()
{
var result = await CallToolAsync(
"azmcp_kusto_table_schema",
new()
{
{ "subscription", Settings.SubscriptionId },
{ "cluster", Settings.ResourceBaseName },
{ "database", TestDatabaseName },
{ "table", TestTableName }
});

var schema = result.AssertProperty("schema").GetString();
Assert.NotNull(schema);
Assert.Contains("Title:string", schema);
Assert.Contains("IsCompleted:bool", schema);
}

[Fact]
public async Task Should_get_table_schema_with_direct_uri()
{
var clusterInfo = await CallToolAsync(
"azmcp_kusto_cluster_get",
new()
{
{ "subscription", Settings.SubscriptionId },
{ "cluster", Settings.ResourceBaseName }
});

var clusterUri = clusterInfo.AssertProperty("cluster").AssertProperty("clusterUri").GetString();
Assert.NotNull(clusterUri);

var result = await CallToolAsync(
"azmcp_kusto_table_schema",
new()
{
{ "cluster-uri", clusterUri },
{ "database", TestDatabaseName },
{ "table", TestTableName }
});

var schema = result.AssertProperty("schema").GetString();
Assert.NotNull(schema);
Assert.Contains("Title:string", schema);
Assert.Contains("IsCompleted:bool", schema);
}
#endregion

#region Query
[Fact]
public async Task Should_query_kusto()
{
Expand All @@ -94,11 +177,40 @@ public async Task Should_query_kusto()
{ "subscription", Settings.SubscriptionId },
{ "cluster", Settings.ResourceBaseName },
{ "database", TestDatabaseName },
{ "query", "ToDoList | take 1" }
{ "query", $"{TestTableName} | take 1" }
});

var itemsArray = result.AssertProperty("items");
Assert.Equal(JsonValueKind.Array, itemsArray.ValueKind);
Assert.NotEmpty(itemsArray.EnumerateArray());
}

[Fact]
public async Task Should_query_kusto_with_direct_uri()
{
var clusterInfo = await CallToolAsync(
"azmcp_kusto_cluster_get",
new()
{
{ "subscription", Settings.SubscriptionId },
{ "cluster", Settings.ResourceBaseName }
});

var clusterUri = clusterInfo.AssertProperty("cluster").AssertProperty("clusterUri").GetString();
Assert.NotNull(clusterUri);

var result = await CallToolAsync(
"azmcp_kusto_query",
new()
{
{ "cluster-uri", clusterUri },
{ "database", TestDatabaseName },
{ "query", $"{TestTableName} | take 1" }
});

var itemsArray = result.AssertProperty("items");
Assert.Equal(JsonValueKind.Array, itemsArray.ValueKind);
Assert.NotEmpty(itemsArray.EnumerateArray());
}
#endregion
}
Loading