Skip to content

Conversation

@prvavill
Copy link
Contributor

@prvavill prvavill commented Sep 25, 2025

…alls

What does this PR do?

fix table schema issue and also adding live tests for missing Kusto calls

when table schema tool is running it responses only with headers which is generic info and actual schema of the table is returned to the clients.

GitHub issue number?

[[Link to the GitHub issue this PR addresses]](#530)

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@prvavill prvavill marked this pull request as ready for review September 25, 2025 20:58
@prvavill prvavill requested review from a team, danield137 and xiangyan99 as code owners September 25, 2025 20:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a table schema issue and adds comprehensive live tests for missing Kusto calls to improve test coverage.

  • Fixes schema retrieval to return complete multi-line schema instead of just the first line
  • Adds live tests for table listing, schema retrieval, and querying using direct cluster URIs
  • Introduces structured test organization with region markers for better maintainability

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
KustoCommandTests.cs Adds comprehensive live tests for Kusto operations and introduces test table constant
KustoService.cs Fixes schema retrieval bug to return complete schema instead of first line only

@vcolin7
Copy link
Contributor

vcolin7 commented Sep 26, 2025

Please add a CHANGELOG entry in the style of the other entries whenever we fix a bug :)

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Sep 26, 2025
@vcolin7 vcolin7 merged commit dfe588f into main Sep 26, 2025
23 of 24 checks passed
@vcolin7 vcolin7 deleted the user/prvavill/table_schema_fix branch September 26, 2025 21:44
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Sep 26, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
…alls (microsoft#579)

* fix table schema issue and also adding live tests for missing Kusto calls

* fix

* updated change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants