-
Notifications
You must be signed in to change notification settings - Fork 98
Fix warning/deprecated msg indentation in help text #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@adewaleo @tjprescott Can you please take a look at this fix? Also the build failures seem unrelated to the change. |
|
@jiasli please take a look at this PR. |
|
We will plan it after Ignite. |
|
The Travis CI build failed. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 167 in repo microsoft/knack |
|
I don't have permission to rerun CI. |
|
And it seems I don't have write access. So my approval is not sufficient. |
|
@atbagga , do you mind fix the test to pass the CI? https://travis-ci.org/microsoft/knack/jobs/648761811#L274 |
Done!! @jiasli |
|
@haroldrandom , is it safe to merge to master? |
haroldrandom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Look so. Please go ahead. |
Fixes #164
Before the fix:

After the fix:
