Skip to content

Conversation

@atbagga
Copy link
Contributor

@atbagga atbagga commented Oct 17, 2019

Fixes #164

  • Before the fix:
    image

  • After the fix:
    image

@atbagga
Copy link
Contributor Author

atbagga commented Oct 17, 2019

@adewaleo @tjprescott Can you please take a look at this fix?

Also the build failures seem unrelated to the change.

@adewaleo
Copy link
Contributor

@atbagga we no longer work on the CLI team. Please reach out to @yonzhan

cc: @qwordy @Juliehzl

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 18, 2019

@jiasli please take a look at this PR.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 18, 2019

We will plan it after Ignite.

@qwordy
Copy link

qwordy commented Oct 24, 2019

The Travis CI build failed.

@qwordy
Copy link

qwordy commented Oct 24, 2019

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 167 in repo microsoft/knack

@qwordy
Copy link

qwordy commented Oct 24, 2019

I don't have permission to rerun CI.

@atbagga atbagga closed this Oct 24, 2019
@atbagga atbagga reopened this Oct 24, 2019
@qwordy
Copy link

qwordy commented Oct 24, 2019

And it seems I don't have write access. So my approval is not sufficient.

Review required
At least 1 approving review is required by reviewers with write access. 

@atbagga
Copy link
Contributor Author

atbagga commented Oct 24, 2019

Thanks @qwordy

Can you also check why is the CI broken? Seems unrelated to my change.

@atbagga
Copy link
Contributor Author

atbagga commented Nov 7, 2019

@jiasli @yonzhan CI seems to be broken for Knack.

I tried a PR with just readme changes and yet it failed - #168

@atbagga atbagga closed this Feb 11, 2020
@atbagga atbagga reopened this Feb 11, 2020
@jiasli
Copy link
Member

jiasli commented Feb 11, 2020

@atbagga , do you mind fix the test to pass the CI? https://travis-ci.org/microsoft/knack/jobs/648761811#L274

@atbagga
Copy link
Contributor Author

atbagga commented Feb 11, 2020

@atbagga , do you mind fix the test to pass the CI? https://travis-ci.org/microsoft/knack/jobs/648761811#L274

Done!! @jiasli

@jiasli
Copy link
Member

jiasli commented Feb 12, 2020

@haroldrandom , is it safe to merge to master?

Copy link

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@haroldrandom
Copy link

@haroldrandom , is it safe to merge to master?

Look so. Please go ahead.

@jiasli jiasli merged commit 4dcea7c into microsoft:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marking command for preview - the preview message should be in the new line and not continue in the long summary

7 participants