Skip to content

Conversation

@ishitam8
Copy link
Member

…ty permission

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

  • : This PR has a corresponding issue open in the Repository.
  • : Approach is signed off on the issue.

Fixes #795

helps['devops security permission update'] = """
type: group
short-summary: Assign allow or deny permission to given user/group.
Learn more at https://aka.ms/azure-devops-cli-security-permission
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO learn more should go in long summary.

e.g. I would not want to show that level of details in this command:

 D:\>az devops security permission -h

Group
    az devops security permission : Manage security permissions.
        This command group is in preview. It may be changed/removed in a future release.
Subgroups:
    namespace : Manage security namespaces.

Commands:
    list      : List tokens for given user/group and namespace.
    reset     : Reset permission for given permission bit(s).
    reset-all : Clear all permissions of this token for a user/group.
    show      : Show permissions for given token, namespace and user/group.
    update    : Assign allow or deny permission to given user/group.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I agree, it will make more sense if we include the link in the long summary.
@geverghe what do you think ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure of how the long summary appears. @atbagga / @ishitam8 any prior examples where long summary has been used to get a sense of how it would look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok got it; makes perfect sense. Including the reference I got from cognitive services that follows the same structure:

long-summary: This article lists the Azure CLI commands for Azure Cognitive Services account and subscription management only. Refer to the documentation at https://docs.microsoft.com/azure/cognitive-services/ for individual services to learn how to use the APIs and supported SDKs.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

This is how it looks if added in long-summary with example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised a fix in Knack for the preview message text to start in new line.
microsoft/knack#167

@ishitam8 ishitam8 merged commit 888df36 into master Oct 17, 2019
@ishitam8 ishitam8 deleted the users/ishitam/docUpdate branch October 18, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update vsts-docs with more examples of adding/removing permission bits

4 participants