chore(extraction-plugin): use ESM imports #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 37bd6399e99ed84bde568d6577a2c737aaeb0444 |
layershifter
force-pushed
the
chore/use-esm-imprort
branch
from
aec42eb to
23229a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #291 I was confused with behavior of Webpack and differences in
require()andimporthandling.The answer is simple:
require()is marked by default as code that contains side effectsimportis marked as side effect free based onpackage.jsonentriesThat explains why it worked in tests and a test project (they didn't have
sideEffects: falsein theirpackage.json), but failed in packages from NPM.That PR changes code to use
importand adds a hook to mark generated files as containing side effects.