chore: remove path magic in extraction process #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against b812096682867be3d15ddb8a2027daf6142ebbf6 |
layershifter
force-pushed
the
chore/use-real-paths
branch
3 times, most recently
from
708ed4a to
4916ceb
Compare
layershifter
commented
Dec 8, 2022
Comment on lines
+100
to
+102
| // Heads up! | ||
| // This is probably a bug, but "import" does not work properly there: files from node_modules are processed, but | ||
| // they will not be present in chunks 😳 |
Member
Author
There was a problem hiding this comment.
This costs me 5 hours of debugging in product, will create an issue in Webpack as it's clearly bug in Webpack or in css-loader/mini-css-extract.
ling1726
approved these changes
Dec 9, 2022
layershifter
force-pushed
the
chore/use-real-paths
branch
from
4916ceb to
3d4aebf
Compare
layershifter
added a commit
to layershifter/griffel
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With changes in this PR we don't use this file anymore. The recipe is described in Webpack's documentation. It was impossible to do it before #277, but now we don't rely on
cacheGroupsanymore.Before
CSS was was emitted to a fake file
griffel.cssin the virtual loader, this file has a path that might look likenode_modules/@griffel/webpack-extraction-plugin/virtual-loader/griffel.css. Image files are relative to the userland codefile, so we had to construct a relative path from the fake CSS file to the image file in userland code.
After
The fake
griffel.cssfile is is under the same path as the original code file, so there is no need to do any changes to the image path since it will already be relative to the original code file.