Changes to Release pipeline to include GarnetServer nuget and other changes to the process #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Garnet Release step and actual Push to Nuget.org
….0.38</Version> from GarnetServer.csproj
Have debug codestill in too.
…e Push to Nuget and Push to GH Release disabled. Also Garnet Library pack uses .nuspec instead of dotnet pack
…e prefix in Directory.Build.props.
… in ADO pipeline output
… seeing if it works when the BuildNumber is updated
…Nuget meta data to Directory.Builds.props.
badrishc
reviewed
Nov 16, 2024
badrishc
reviewed
Nov 16, 2024
…Directory.Build.props. Push to GH Release and Push to Nuget ARE DISABLED for this check in to be able to test first
badrishc
approved these changes
Nov 18, 2024
…Push to Nuget and Push to Github release are NOT enabled until we test through in actual pipeline
badrishc
reviewed
Nov 19, 2024
…dbs in nupkg since it is a dotnet tool
…icrosoft/garnet into darrenge/ReleaseOfGarnetServer
… where it WILL PUSH TO NUGET.ORG and create a GH Release. This release has no pdb files in the nupkg package and only Garnet.Host.pdb in the .snupkg file.
…ush to Nuget.org is now ENABLED.
badrishc
approved these changes
Nov 22, 2024
…et EmbedUntrackedSources to truefor Garnet.host
…p since they are closerly related
badrishc
approved these changes
Nov 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sizable PR with the two main goals:
A secondary goal was to get away from .nuspec and use dotnet pack to create the nuget packages.
Directory.Build.props - this gives us the single place for the version as well as the shared meta data of the nuget packages
azure-pipelines-external-release.yml - uses dotnet pack; packs GarnetServer; no longer has the hard coded build name that needed to be updated
extract-version.ps1 - gets build name \ version from Directory.Build.props and sets version for yml and updates build number
Garnet.host.csproj - csproj that gets built that provides all the files for the Microsoft.Garnet nuget package. Modified so dotnet pack can be used instead of nuget pack
GarnetServer.csproj - mostly just moving things out to the shared location of Directory.Build.props
Garnet.sln - deleted the Garnet.nuspec as it is no longer needed since using dotnet pack
This will fix issue #793