Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated garnet-server version #793

Closed
Meir017 opened this issue Nov 12, 2024 · 0 comments · Fixed by #809
Closed

Remove duplicated garnet-server version #793

Meir017 opened this issue Nov 12, 2024 · 0 comments · Fixed by #809
Assignees
Labels

Comments

@Meir017
Copy link
Contributor

Meir017 commented Nov 12, 2024

Feature request type

enhancement

Is your feature request related to a problem? Please describe

The version of the garnet-server component is duplicated in 3 locations
Image

I think we should reduce this to be defined in a single location and have the other location reference this value.

See an example commit 0ab8af6

Describe the solution you'd like

I think the only location that should define this value is the main/GarnetServer/GarnetServer.csproj file.

Then to allow the code at libs/host/GarnetServer.cs to reference this we could use something similar to https://stackoverflow.com/a/49537163/7025656 and expose an assembly-level attribute to the code through msbuild properties.

For .azure/pipelines/azure-pipelines-external-release.yml we could leverage the command ##vso[build.updatebuildnumber]build number through a powershell script that will read the msbuild property and modify the build's name

Describe alternatives you've considered

No response

Additional context

No response

@Meir017 Meir017 changed the title Remove duplicated garnet version Remove duplicated garnet-server version Nov 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants