Skip to content

Use lib: es5 to prevent IE 11 breaks #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecraig12345 merged 1 commit into from
Mar 26, 2019
Merged

Use lib: es5 to prevent IE 11 breaks #8414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions apps/fabric-website-resources/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,8 @@
"noImplicitAny": true,
"moduleResolution": "node",
"preserveConstEnums": true,
"lib": [
"es2017",
"dom"
],
"types": [
"jest",
"webpack-env"
]
"lib": ["es5", "dom"],
"types": ["jest", "webpack-env"]
},
"include": [
"src"
]
}
"include": ["src"]
}
3 changes: 2 additions & 1 deletion apps/todo-app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"moduleResolution": "node",
"preserveConstEnums": true,
"strict": true,
"lib": ["es6", "dom"],
"skipLibCheck": true,
"lib": ["es5", "dom"],
"types": ["webpack-env"]
},
"include": ["src"]
Expand Down
11 changes: 11 additions & 0 deletions common/changes/@uifabric/azure-themes/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/azure-themes",
"type": "none"
}
],
"packageName": "@uifabric/azure-themes",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/charting/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/charting",
"comment": "Remove IE 11-incompatible constructs",
"type": "patch"
}
],
"packageName": "@uifabric/charting",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/dashboard/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/dashboard",
"comment": "Remove IE 11-incompatible constructs",
"type": "minor"
}
],
"packageName": "@uifabric/dashboard",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/date-time/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/date-time",
"type": "none"
}
],
"packageName": "@uifabric/date-time",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/example-app-base/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/example-app-base",
"type": "none"
}
],
"packageName": "@uifabric/example-app-base",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/experiments/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/experiments",
"type": "none"
}
],
"packageName": "@uifabric/experiments",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/fabric-website-resources/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/fabric-website-resources",
"type": "none"
}
],
"packageName": "@uifabric/fabric-website-resources",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/file-type-icons/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/file-type-icons",
"type": "none"
}
],
"packageName": "@uifabric/file-type-icons",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/fluent-theme/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/fluent-theme",
"type": "none"
}
],
"packageName": "@uifabric/fluent-theme",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/foundation/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/foundation",
"type": "none"
}
],
"packageName": "@uifabric/foundation",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/icons/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/icons",
"type": "none"
}
],
"packageName": "@uifabric/icons",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/jest-serializer-merge-styles/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/jest-serializer-merge-styles",
"type": "none"
}
],
"packageName": "@uifabric/jest-serializer-merge-styles",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/merge-styles/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/merge-styles",
"type": "none"
}
],
"packageName": "@uifabric/merge-styles",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/migration/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/migration",
"type": "none"
}
],
"packageName": "@uifabric/migration",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/react-cards/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Remove IE 11-incompatible constructs",
"packageName": "@uifabric/react-cards",
"type": "patch"
}
],
"packageName": "@uifabric/react-cards",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/styling/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/styling",
"type": "none"
}
],
"packageName": "@uifabric/styling",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/theme-samples/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/theme-samples",
"type": "none"
}
],
"packageName": "@uifabric/theme-samples",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/utilities/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/utilities",
"type": "none"
}
],
"packageName": "@uifabric/utilities",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/variants/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/variants",
"type": "none"
}
],
"packageName": "@uifabric/variants",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/webpack-utils/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/webpack-utils",
"type": "none"
}
],
"packageName": "@uifabric/webpack-utils",
"email": "elcraig@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/lib_2019-03-21-17-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Remove IE 11-incompatible constructs",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "elcraig@microsoft.com"
}
17 changes: 4 additions & 13 deletions packages/azure-themes/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,11 @@
"noImplicitAny": true,
"moduleResolution": "node",
"preserveConstEnums": true,
"lib": [
"es2017",
"dom"
],
"lib": ["es5", "dom"],
"paths": {
"@uifabric/azure-themes/lib/*": [
"./src/*"
],
"@uifabric/azure-themes": [
"./src"
]
"@uifabric/azure-themes/lib/*": ["./src/*"],
"@uifabric/azure-themes": ["./src"]
}
},
"include": [
"src"
]
"include": ["src"]
}
4 changes: 2 additions & 2 deletions packages/charting/src/components/HorizontalBarChart/HorizontalBarChart.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { classNamesFunction } from 'office-ui-fabric-react/lib/Utilities';
import { classNamesFunction, find } from 'office-ui-fabric-react/lib/Utilities';
import { IProcessedStyleSet, IPalette } from 'office-ui-fabric-react/lib/Styling';
import { IChartProps, IHorizontalBarChartProps, IHorizontalBarChartStyles, IChartDataPoint } from './index';
import { Callout, DirectionalHint } from 'office-ui-fabric-react/lib/Callout';
Expand Down Expand Up @@ -129,7 +129,7 @@ export class HorizontalBarChartBase extends React.Component<IHorizontalBarChartP
private _hoverOn(hoverValue: string | number | Date | null, lineColor: string, legend: string): void {
if (!this.state.isCalloutVisible || this.state.legend !== legend) {
const refArray = this.state.refArray;
const currentHoveredElement = refArray.find((currentElement: IRefArrayData) => currentElement.legendText === legend);
const currentHoveredElement = find(refArray, (currentElement: IRefArrayData) => currentElement.legendText === legend);
this.setState({
isCalloutVisible: true,
hoverValue: hoverValue,
Expand Down
4 changes: 2 additions & 2 deletions packages/charting/src/components/Legends/Legends.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';

import { IContextualMenuItem } from 'office-ui-fabric-react/lib/ContextualMenu';
import { HoverCard, HoverCardType, IExpandingCardProps } from 'office-ui-fabric-react/lib/HoverCard';
import { classNamesFunction } from 'office-ui-fabric-react/lib/Utilities';
import { classNamesFunction, find } from 'office-ui-fabric-react/lib/Utilities';
import { ResizeGroup } from 'office-ui-fabric-react/lib/ResizeGroup';
import { IProcessedStyleSet } from 'office-ui-fabric-react/lib/Styling';
import { OverflowSet, IOverflowSetItemProps } from 'office-ui-fabric-react/lib/OverflowSet';
Expand Down Expand Up @@ -154,7 +154,7 @@ export class LegendsBase extends React.Component<ILegendsProps, ILegendState> {
// execute similar to "_onClick" and "_onLeave" logic at HoverCard onCardHide event
const onHoverCardHideHandler = () => {
if (this.state.selectedState) {
const selectedOverflowItem = legends.find((legend: ILegend) => legend.title === this.state.selectedLegend);
const selectedOverflowItem = find(legends, (legend: ILegend) => legend.title === this.state.selectedLegend);
if (selectedOverflowItem) {
this.setState({ selectedLegend: 'none', selectedState: false }, () => {
if (selectedOverflowItem.action) {
Expand Down
2 changes: 1 addition & 1 deletion packages/charting/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"noImplicitAny": true,
"moduleResolution": "node",
"preserveConstEnums": true,
"lib": ["es2017", "dom"],
"lib": ["es5", "dom"],
"types": ["jest", "webpack-env"],
"paths": {
"@uifabric/charting/lib/*": ["./src/*"],
Expand Down
Loading