Use lib: es5 to prevent IE 11 breaks by ecraig12345 · Pull Request #8414 · microsoft/fluentui

ecraig12345 · 2019-03-21T02:29:15Z

Pull request checklist

Addresses an existing issue: Fixes #0000
Include a change request file using $ npm run change

Description of changes

Currently we rely on code reviews to prevent ES6 methods and objects, which aren't supported in IE 11, from slipping into our code. Switching all projects which run in the browser to use "lib": ["es5"] (and possibly other relevant libs) in tsconfig.json will prevent these issues.

Related changes:

Replace instances of ES6 things with ES5-compatible things
Add "skipLibCheck": true to tsconfig.json for projects which have dependencies whose typings use ES6 types
In a couple instances where the usage is safe, add file-level declarations for Set/Map/WeakMap--either for tests (which run in Node not the browser) or one place where it checks for the class's existence before using it

Microsoft Reviewers: Open in CodeFlow

ecraig12345 · 2019-03-21T02:31:53Z

packages/dashboard/tsconfig.json

    "preserveConstEnums": true,
-    "lib": ["es2017", "dom"],
+    "skipLibCheck": true,
+    "lib": ["es5", "es2015.promise", "dom"],


@Raghurk I noticed there are several components in dashboard which use Promise. Do you require all consumers to provide a Promise polyfill (for IE 11 support)?

ecraig12345 · 2019-03-21T02:38:40Z

packages/office-ui-fabric-react/src/components/ScrollablePane/ScrollablePane.base.tsx

  private _contentContainer = React.createRef<HTMLDivElement>();
-  private _subscribers: Set<Function>;
-  private _stickies: Set<Sticky>;
+  private _subscribers: Function[];


Switched Set to arrays here--more verbose but should hopefully have the same behavior

Awesome catch!!!

packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.base.tsx

size-auditor · 2019-03-21T02:53:41Z

Bundle test	Size (minified)	Diff from master
DatePicker	199.315 kB	49 bytes
Calendar	143.597 kB	49 bytes
DetailsList	208.82 kB	-137 bytes
ShimmeredDetailsList	219.644 kB	-137 bytes

Exceeds Tolerance Exceeds Baseline Below Baseline 1 kB = 1000 bytes

kenotron

Thanks for doing this work!

kenotron · 2019-03-21T15:48:20Z

packages/office-ui-fabric-react/src/components/ScrollablePane/ScrollablePane.base.tsx

  private _contentContainer = React.createRef<HTMLDivElement>();
-  private _subscribers: Set<Function>;
-  private _stickies: Set<Sticky>;
+  private _subscribers: Function[];


Awesome catch!!!

kenotron · 2019-03-21T15:52:12Z

needs rush change :(

packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.base.tsx

ecraig12345 · 2019-03-21T21:14:36Z

Planning to merge this EOD today. If anyone who hasn't reviewed wants to take a look before I merge, please do so now (or leave a comment asking me to wait).

dzearing · 2019-03-21T21:37:54Z

@ecraig12345 Nice work!!!

ecraig12345 · 2019-03-21T23:26:00Z

Waiting to merge until I can implement David's suggestion about declaring IE11-compat versions of Set and Map somewhere. (see #8421 (comment) )

ecraig12345 · 2019-03-25T21:04:55Z

Updated the PR to add a typings folder at the root with a custom-global package inside (with partial Set/Map/WeakMap types), then referenced that extra typing in oufr, experiments, and utilities (can be added elsewhere as needed).

So this time I really do intend to merge EOD unless someone objects.

ecraig12345 · 2019-03-26T01:45:27Z

Merged. If anyone prefers a different approach to the Set/Map typings, let me know and we can revisit the issue.

msft-github-bot · 2019-03-27T12:37:40Z

🎉@uifabric/dashboard@v0.58.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot · 2019-03-27T12:37:41Z

🎉@uifabric/charting@v0.28.10 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot · 2019-03-27T12:37:41Z

🎉@uifabric/react-cards@v0.1.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot · 2019-03-27T12:37:45Z

🎉office-ui-fabric-react@v6.161.0 has been released which incorporates this pull request.:tada:

Handy links:

ecraig12345 requested review from annapablo and kenotron March 21, 2019 02:29

ecraig12345 requested review from a team, Jahnp, JasonGore, KevinTCoughlin, Raghurk, dzearing and joschect as code owners March 21, 2019 02:29

msft-github-bot assigned KevinTCoughlin Mar 21, 2019

ecraig12345 commented Mar 21, 2019

View reviewed changes

kenotron approved these changes Mar 21, 2019

View reviewed changes

ecraig12345 mentioned this pull request Mar 21, 2019

FocusZone: reduce global event listeners #8421

Merged

KevinTCoughlin reviewed Mar 21, 2019

View reviewed changes

packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.base.tsx Show resolved Hide resolved

KevinTCoughlin approved these changes Mar 21, 2019

View reviewed changes

ecraig12345 added the Status: Do Not Merge 🚫 label Mar 21, 2019

Use lib: es5 to prevent IE 11 breaks and add custom global

b3f4038

ecraig12345 force-pushed the lib branch from a0c86b9 to b3f4038 Compare March 23, 2019 15:27

ecraig12345 removed the Status: Do Not Merge 🚫 label Mar 25, 2019

ecraig12345 merged commit 91c5719 into microsoft:master Mar 26, 2019

ecraig12345 deleted the lib branch March 26, 2019 01:45

microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019

Conversation

ecraig12345 commented Mar 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request checklist

Description of changes

Microsoft Reviewers: Open in CodeFlow

Uh oh!

ecraig12345 Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

ecraig12345 Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

kenotron Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

size-auditor bot commented Mar 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenotron left a comment

Choose a reason for hiding this comment

Uh oh!

kenotron Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

kenotron commented Mar 21, 2019

Uh oh!

Uh oh!

ecraig12345 commented Mar 21, 2019

Uh oh!

dzearing commented Mar 21, 2019

Uh oh!

ecraig12345 commented Mar 21, 2019

Uh oh!

ecraig12345 commented Mar 25, 2019

Uh oh!

ecraig12345 commented Mar 26, 2019

Uh oh!

msft-github-bot commented Mar 27, 2019

Uh oh!

msft-github-bot commented Mar 27, 2019

Uh oh!

msft-github-bot commented Mar 27, 2019

Uh oh!

msft-github-bot commented Mar 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ecraig12345 commented Mar 21, 2019 •

edited

Loading

size-auditor bot commented Mar 21, 2019 •

edited

Loading