Shimmer: change prop use of subcomponents. #5559
Conversation
|
Sorry about the merge conflict. This fixes the copy of Shimmer in OUFR but not the one in experiments.. May I strongly recommend reconciling the fact that they're now forking? Either by removing the duplication or making the changes in both places. Also, it might be good to add an example using the styles API to demonstrate how to customize the borderStyle (and to verify that it still works) :) |
| /** | ||
| * Sets custom styling of the gap. | ||
| */ | ||
| borderStyle?: IStyleSet; |
There was a problem hiding this comment.
@dzearing are you okay with removing this prop? It is technically a breaking change...
An alternative is just to change the type to any and add @deprecated. (Would be even nicer if we could use TS 3.0's unknown type instead for deprecation).
There was a problem hiding this comment.
Unless it was a blocking bug, this should be @deprecated and not removed.
|
Request review and input from @dzearing as well. |
|
@cliffkoh I will wait on you PR #5609 to get merged as it will cause some conflicts again. Also I can add to this PR a re-export of Shimmer from experiments package pointing to the one from OUFR and remove the code. The caveat is that this would be a breaking change for anyone who used Shimmer from V6 of the experiments package as it uses a prop removed from the one in OUFR. Let me know how to proceed? |
|
@Vitalius1 can you clean up conflicts and deprecate the prop? |
| ); | ||
| const showTooltip = isTooltipVisible && isContentPresent; | ||
| const ariaDescribedBy = (setAriaDescribedBy && isTooltipVisible && isContentPresent) ? tooltipId : undefined; | ||
| const ariaDescribedBy = setAriaDescribedBy && isTooltipVisible && isContentPresent ? tooltipId : undefined; |
There was a problem hiding this comment.
This line was changed by the auto formatter (prettier) after merging a fresh master and resolving the conflicts.
3 participants
Pull request checklist
$ npm run changeDescription of changes
Removing use of
borderStyleprop of Shimmer subcomponents in favor of using mergeStyles API.Microsoft Reviewers: Open in CodeFlow