Shimmer: change prop use of subcomponents Line, Circle and Gap.#5739
Merged
Vitalius1 merged 6 commits intomicrosoft:masterfrom Jul 31, 2018
Merged
Shimmer: change prop use of subcomponents Line, Circle and Gap.#5739Vitalius1 merged 6 commits intomicrosoft:masterfrom
Vitalius1 merged 6 commits intomicrosoft:masterfrom
Conversation
added 3 commits
July 31, 2018 11:06
…r of 'styles' to leverage the 'mergerStyles' API.
1 task
Contributor
cliffkoh
reviewed
Jul 31, 2018
| @@ -11,12 +11,11 @@ export function getStyles(props: IShimmerGapStyleProps): IShimmerGapStyles { | |||
| const { palette } = theme; | |||
| const classNames = getGlobalClassNames(GlobalClassNames, theme); | |||
Contributor
There was a problem hiding this comment.
classNames [](start = 8, length = 10)
nit: rename these to globalClassNames so it is clearer e.g. in line 18
Contributor
cliffkoh
approved these changes
Jul 31, 2018
Contributor
cliffkoh
left a comment
cliffkoh
left a comment
There was a problem hiding this comment.
Superficially, looks good but I have a few nits/suggestions for improvement.
Contributor
|
👍 👍 Thanks for making the changes suggested. |
nulikartik
pushed a commit
to nulikartik/office-ui-fabric-react
that referenced
this pull request
Aug 1, 2018
…osoft#5739) * Adds deprecation message and renames constant 'styles' to 'borderStyles'. * Change the use of 'borderStyle' prop on shimmer subcomponents in favor of 'styles' to leverage the 'mergerStyles' API. * Change log. * Remove unnecessary style. * Rename a constant in styles of Shimmer subcomponents for improved semantics. * Adds documentation to subcomponents interfaces.
Vitalius1
added a commit
to Vitalius1/office-ui-fabric-react
that referenced
this pull request
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Removing use of borderStyle prop of Shimmer subcomponents in favor of using mergeStyles API.
Microsoft Reviewers: Open in CodeFlow