Skip to content

Addressing Issue #5165 - Using Customizer with Nav Component#5361

Merged
oengusmacinog-zz merged 3 commits intomicrosoft:masterfrom
oengusmacinog-zz:nav-customizer-5165
Jun 28, 2018
Merged

Addressing Issue #5165 - Using Customizer with Nav Component#5361
oengusmacinog-zz merged 3 commits intomicrosoft:masterfrom
oengusmacinog-zz:nav-customizer-5165

Conversation

@oengusmacinog-zz
Copy link
Copy Markdown
Collaborator

@oengusmacinog-zz oengusmacinog-zz commented Jun 27, 2018

Pull request checklist

Description of changes

Updates made to the styles infrastructure now require an extra argument in the use of the styled() function in the main component file (e.g. Nav.tsx) in lieu of the @Customizable decorator used in the past.

Microsoft Reviewers: Open in CodeFlow

Copy link
Copy Markdown
Contributor

@bennettclark bennettclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oengusmacinog-zz oengusmacinog-zz merged commit c58b958 into microsoft:master Jun 28, 2018
@oengusmacinog-zz oengusmacinog-zz deleted the nav-customizer-5165 branch June 28, 2018 02:51
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Jul 1, 2018
* master: (151 commits)
  Css updates for card components (microsoft#5393)
  DatePicker MergeStyles step 2 - Converts scss to js styles (microsoft#5362)
  Update stale with 60 day comment and updated ignored label names. (microsoft#5388)
  replaced await for ie compat syntax - but still needs promise (microsoft#5387)
  Slider - mergestyle conversion (microsoft#5379)
  Applying package updates.
  Enabling publishing for charting and gridlayout. (microsoft#5378)
  TilesList: fadeOut overlay. (microsoft#5381)
  Pivot: JS Styling (microsoft#5324)
  ShimmeredDetailsList: wrapper for DetailsList with Shimmer. (microsoft#5374)
  dashboard-grid-layout improved example (microsoft#5373)
  Applying package updates.
  Addressing Issue microsoft#5165 - Using Customizer with Nav Component (microsoft#5361)
  Applying package updates.
  Address issue microsoft#5353 (microsoft#5359)
  Change log to trigger release (microsoft#5358)
  Fluent updates (microsoft#5357)
  TextField render value undefined as empty string (microsoft#5349)
  Applying package updates.
  DetailsColumn: css class changes to show gripper when hover on draggable columns (microsoft#5309)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Customizer with Nav Component

2 participants