Merged
Conversation
…how flexbox handles placement of the toggle element
oengusmacinog-zz
approved these changes
Jun 27, 2018
Collaborator
oengusmacinog-zz
left a comment
oengusmacinog-zz
left a comment
There was a problem hiding this comment.
Had a question on some padding, but assuming there is probably a reason this looks good to go.
| width: '40px', | ||
| height: '20px', | ||
| borderRadius: '10px', | ||
| padding: '0 4px' |
Collaborator
There was a problem hiding this comment.
Why the side padding?
Contributor
Author
There was a problem hiding this comment.
It's the same side padding value in the pre-fluent styles currently in use by Toggle, but it's in ems in the pre-fluent component styles, so I added the px style here to uniformly update to px from em.
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jul 1, 2018
* master: (151 commits) Css updates for card components (microsoft#5393) DatePicker MergeStyles step 2 - Converts scss to js styles (microsoft#5362) Update stale with 60 day comment and updated ignored label names. (microsoft#5388) replaced await for ie compat syntax - but still needs promise (microsoft#5387) Slider - mergestyle conversion (microsoft#5379) Applying package updates. Enabling publishing for charting and gridlayout. (microsoft#5378) TilesList: fadeOut overlay. (microsoft#5381) Pivot: JS Styling (microsoft#5324) ShimmeredDetailsList: wrapper for DetailsList with Shimmer. (microsoft#5374) dashboard-grid-layout improved example (microsoft#5373) Applying package updates. Addressing Issue microsoft#5165 - Using Customizer with Nav Component (microsoft#5361) Applying package updates. Address issue microsoft#5353 (microsoft#5359) Change log to trigger release (microsoft#5358) Fluent updates (microsoft#5357) TextField render value undefined as empty string (microsoft#5349) Applying package updates. DetailsColumn: css class changes to show gripper when hover on draggable columns (microsoft#5309) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Updated fluent styles for toggle pill and thumb dimensions, padding, border-radius, etc from em to px.
Microsoft Reviewers: Open in CodeFlow