Skip to content

Global scss: Add global name to files using global for tagging in sideEffects #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Jun 6, 2018
Merged

Global scss: Add global name to files using global for tagging in sideEffects #5126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d58d557
Add global to files using global to tag in sideEffects
lynamemi Jun 6, 2018
d04fad4
Add change file
lynamemi Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/fix-globals_2018-06-06-22-18.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Add global name to scss files using global selector to tag in sideEffects.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "lynam.emily@gmail.com"
}
6 changes: 5 additions & 1 deletion packages/office-ui-fabric-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
"description": "Reusable React components for building experiences for Office 365.",
"main": "lib-commonjs/index.js",
"module": "lib/index.js",
"sideEffects": false,
"sideEffects": [
"*.global.js",
Copy link
Copy Markdown
Collaborator Author

@lynamemi lynamemi Jun 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check these file paths...

"*Examples.js",
"*Example.js"
],
"typings": "lib/index.d.ts",
"repository": {
"type": "git",
Expand Down
0 ...c/components/HoverCard/HoverCardPage.scss → ...nents/HoverCard/HoverCardPage.global.scss
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { IDemoPageProps } from '../../demo/components/DemoPage.types';
import { HoverCardTargetExample } from './examples/HoverCard.Target.Example';
import { HoverCardStatus } from './HoverCard.checklist';

import './HoverCardPage.scss';
import './HoverCardPage.global.scss';

const HoverCardBasicExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/HoverCard/examples/HoverCard.Basic.Example.tsx') as string;
const HoverCardTargetExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/HoverCard/examples/HoverCard.Target.Example.tsx') as string;
Expand Down
0 ...react/src/components/Image/ImagePage.scss → ...rc/components/Image/ImagePage.global.scss
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Image/ImagePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import './ImagePage.scss';
import './ImagePage.global.scss';
import { DemoPage } from '../../demo/components/DemoPage';
import { IDemoPageProps } from '../../demo/components/DemoPage.types';
import { ImageDefaultExample } from './examples/Image.Default.Example';
Expand Down
0 ...ts/ThemeGenerator/ThemeGeneratorPage.scss → ...eGenerator/ThemeGeneratorPage.global.scss
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import './ThemeGeneratorPage.scss';
import './ThemeGeneratorPage.global.scss';
import { BaseComponent } from 'office-ui-fabric-react/lib/Utilities';

import { loadTheme } from 'office-ui-fabric-react/lib/Styling';
Expand Down
0 ...t/src/components/Tooltip/TooltipPage.scss → ...omponents/Tooltip/TooltipPage.global.scss
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { TooltipInteractiveExample } from './examples/Tooltip.Interactive.Exampl
import { TooltipOverflowExample } from './examples/Tooltip.Overflow.Example';
import { TooltipStatus } from './Tooltip.checklist';

import './TooltipPage.scss';
import './TooltipPage.global.scss';

const TooltipBasicExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/Tooltip/examples/Tooltip.Basic.Example.tsx') as string;
const TooltipCustomExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/Tooltip/examples/Tooltip.Custom.Example.tsx') as string;
Expand Down