Global scss: Add global name to files using global for tagging in sideEffects#5126
Merged
dzearing merged 2 commits intomicrosoft:masterfrom Jun 6, 2018
Merged
Global scss: Add global name to files using global for tagging in sideEffects#5126dzearing merged 2 commits intomicrosoft:masterfrom
dzearing merged 2 commits intomicrosoft:masterfrom
Conversation
lynamemi
commented
Jun 6, 2018
| "module": "lib/index.js", | ||
| "sideEffects": false, | ||
| "sideEffects": [ | ||
| "*.global.js", |
Collaborator
Author
There was a problem hiding this comment.
Double check these file paths...
kenotron
approved these changes
Jun 6, 2018
phkuo
approved these changes
Jun 6, 2018
dzearing
approved these changes
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Addresses an existing issue: Fixes #0000
[X] Include a change request file using
$ npm run changeDescription of changes
The OUIFR package had sideEffects: false set in the package.json to allow tree shaking. On the Fabric website, this resulted in a large number of the example pages losing important styles.
Since most of the example scss files use the :global{} selection wrapper, I added those files to the sideEffects array. Any non-example scss file that also used :global{} got a .global. added to its filename and all global-named files went into the array, also.
Later, we need to convert these files to modular css.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow