Skip to content

Revert react portals change #4840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jspurlin merged 5 commits into from
May 11, 2018
Merged

Revert react portals change #4840

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5beb8c5
Revert "Move <Layer> to use React portals when available (#4724)"
MLoughry May 10, 2018
5d24da1
Add change file
MLoughry May 10, 2018
b7971a5
Address comment
MLoughry May 10, 2018
2c302ed
Re-add enzyme-to-json
MLoughry May 10, 2018
e47d1da
Pin markdown-to-jsx dependency
jspurlin May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/revert-react-portals_2018-05-10-22-27.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Revert change to use React.createPortal, until focus leaking issues can be resolved",
Copy link
Contributor

@jspurlin jspurlin May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generalize this comment to be "... until event leaking issues can be resolved"

"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
104 changes: 44 additions & 60 deletions common/config/rush/npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/example-app-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@uifabric/styling": ">=5.30.1 <6.0.0",
"@uifabric/utilities": ">=5.30.1 <6.0.0",
"highlight.js": "^9.12.0",
"markdown-to-jsx": "6.6.1",
"markdown-to-jsx": "^6.6.0",
"office-ui-fabric-react": ">=5.1.0 <6.0.0",
"react-syntax-highlighter": "^7.0.2",
"tslib": "^1.7.1"
Expand Down
3 changes: 1 addition & 2 deletions packages/office-ui-fabric-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@
"@uifabric/example-app-base": ">=5.11.3 <6.0.0",
"enzyme": "^3.2.0",
"enzyme-adapter-react-16": "^1.1.0",
"enzyme-to-json": "^3.3.3",
"es6-map": "^0.1.5",
"es6-promise": "^4.1.0",
"es6-map": "^0.1.5",
"es6-weak-map": "^2.0.2",
"highlight.js": "^9.12.0",
"office-ui-fabric-core": ">=9.0.0 <10.0.0",
Expand Down
Loading