Revert react portals change #4840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 0283f2a.
jspurlin
reviewed
May 10, 2018
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Revert change to use React.createPortal, until focus leaking issues can be resolved", |
Contributor
There was a problem hiding this comment.
generalize this comment to be "... until event leaking issues can be resolved"
jspurlin
approved these changes
May 10, 2018
joschect
approved these changes
May 10, 2018
sayali26
approved these changes
May 10, 2018
cliffkoh
approved these changes
May 10, 2018
cschleiden
suggested changes
May 11, 2018
| const portalSupport: boolean = !!ReactDOM.createPortal; | ||
|
|
||
| export const Layer = styled<ILayerProps, ILayerStyleProps, ILayerStyles>( | ||
| portalSupport ? PortalLayerBase : LayerBase, |
Contributor
There was a problem hiding this comment.
Just set this flag to false for now?
Contributor
There was a problem hiding this comment.
If we want to create a release without the change, that would be the least invasive change I feel and would make it easier for forward fix the components that might have changed behavior.
You should be able to validate with a conditional breakpoint that changes this var
cschleiden
approved these changes
May 11, 2018
ThomasMichon
approved these changes
May 11, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 13, 2018
…i-fabric-react into parallel-tsc * 'parallel-tsc' of https://github.com/Markionium/office-ui-fabric-react: Variants: have project use OUFR instead of just styling (microsoft#4854) Add more customization hooks to ProgressIndicator (microsoft#4566) Issue#4832: Break BaseButton Types hard dependency from class ContextualMenu (microsoft#4845) Applying package updates. Revert react portals change (microsoft#4840) Update ImageOverview.md Fixes duplicate reading of suggestions on people picker (microsoft#4765) Persona: Deprecate primaryText (microsoft#4811) Experiments: Fix Fluent theme color names (microsoft#4834) Applying package updates. Add JasonGore to command bar codeowners Fix index import (microsoft#4826) Added overflowMenuProps property to CommandBar (microsoft#4818) Fluent theme: Fix imports to use relative paths (microsoft#4831) ContextualMenuItem: adding secondaryText (microsoft#4788) ComboBox: Option Performance Optimization (microsoft#4782)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 13, 2018
* master: (95 commits) Variants: have project use OUFR instead of just styling (microsoft#4854) Add more customization hooks to ProgressIndicator (microsoft#4566) Issue#4832: Break BaseButton Types hard dependency from class ContextualMenu (microsoft#4845) Applying package updates. Revert react portals change (microsoft#4840) Update ImageOverview.md Fixes duplicate reading of suggestions on people picker (microsoft#4765) Persona: Deprecate primaryText (microsoft#4811) Experiments: Fix Fluent theme color names (microsoft#4834) Applying package updates. Add JasonGore to command bar codeowners Fix index import (microsoft#4826) Added overflowMenuProps property to CommandBar (microsoft#4818) Fluent theme: Fix imports to use relative paths (microsoft#4831) ContextualMenuItem: adding secondaryText (microsoft#4788) ComboBox: Option Performance Optimization (microsoft#4782) Marqueeselection style update (microsoft#4803) Applying package updates. FocusZone: Add the ability to stop focus from propagating outside the FocusZone (microsoft#4823) Unknown persona coin (microsoft#4809) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The change to use React portals is breaking key focus scenarios for both OWA and WAC. Backing this out until such issues can be more thoroughly investigated.
Focus areas to test
(optional)