Skip to content

Remove usage of Number.NaN #4615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Apr 19, 2018
Merged

Remove usage of Number.NaN #4615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dac8abc
Number.isNaN does not exist in IE11
christiango Apr 19, 2018
ce47952
Rush change
christiango Apr 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/IE11-NaN_2018-04-19-15-14.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Remove usage of Number.isNaN from SpinButton.tsx since it doesn't exist in IE11",
Copy link
Contributor

@cliffkoh cliffkoh Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpinButton: Handle the case where Number.isNaN is not supported in IE 11

"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/SpinButton/SpinButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ export class SpinButton extends BaseComponent<ISpinButtonProps, ISpinButtonState
type='text'
role='spinbutton'
aria-labelledby={ label && this._labelId }
aria-valuenow={ !Number.isNaN(Number(value)) ? Number(value) : undefined }
aria-valuetext={ Number.isNaN(Number(value)) ? value : undefined }
aria-valuenow={ !isNaN(Number(value)) ? Number(value) : undefined }
Copy link
Contributor

@cliffkoh cliffkoh Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more robust to check if Number.isNaN is a defined function and if so, to use it rather than rely on the less reliable, global isNaN function all the time.

Copy link
Contributor

@jspurlin jspurlin Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cliffkoh, this is the only usage of Number.isNaN that I could find in fabric, everywhere else uses isNaN

aria-valuetext={ isNaN(Number(value)) ? value : undefined }
aria-valuemin={ min }
aria-valuemax={ max }
onBlur={ this._onBlur }
Expand Down