Skip to content

Choicegroup: Improved states for focus, HC focus, HC hover #4572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynamemi merged 3 commits into from
Apr 18, 2018
Merged

Choicegroup: Improved states for focus, HC focus, HC hover #4572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a78c392
High contrast focus and hover + regular focus fix
lynamemi Apr 16, 2018
56b9b8c
Added change file
lynamemi Apr 16, 2018
151f98e
In HC, highlighting text on hover, too
lynamemi Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/choicegroup-focus_2018-04-16-21-59.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ChoiceGroup: Style polish for focus, high contrast focus, and high contrast hover.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "lynam.emily@gmail.com"
}
17 changes: 15 additions & 2 deletions packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,18 @@ $ms-choiceField-transition-timing: cubic-bezier(.4, 0, .23, 1);
&:focus {
&::before {
border-color: $radioButton-border-hover-color;

@include high-contrast {
border-color: Highlight;
}
}

:global(.ms-Label) {
color: $radioButton-text-hover-color;

@include high-contrast {
color: Highlight;
}
}
}

Expand Down Expand Up @@ -302,6 +310,11 @@ $ms-choiceField-transition-timing: cubic-bezier(.4, 0, .23, 1);
&:focus {
border-color: $ms-color-neutralTertiaryAlt;

@include high-contrast {
border-color: Highlight;
color: Highlight;
}

&::before {
opacity: 1;
}
Expand Down Expand Up @@ -367,10 +380,10 @@ $ms-choiceField-transition-timing: cubic-bezier(.4, 0, .23, 1);
:global(.ms-Fabric.is-focusVisible) .choiceFieldIsInFocus {
&.choiceFieldIsImage .choiceFieldWrapper,
&.choiceFieldIsIcon .choiceFieldWrapper {
@include focus-border(1px, $ms-color-neutralPrimary, 2px, false);
@include focus-border(-2px, $ms-color-neutralSecondary, 1px, false);

@include high-contrast {
@include focus-border(1px, WindowText, 2px, false);
@include focus-border(-2px, WindowText, 1px, false);
}
}
}