Skip to content

Fix style and alignment issues in the DetailsList header #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aditima merged 5 commits into from
Apr 12, 2018
Merged

Fix style and alignment issues in the DetailsList header #4487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce85f9b
Add missing hover and activate style slots to DetailsHeader
ThomasMichon Apr 7, 2018
ae3fe61
Fix phantom aria-describedby attribute
ThomasMichon Apr 7, 2018
8c9acd1
Fix overflow of headers caused by status icons
ThomasMichon Apr 7, 2018
1f9bb4c
Update change output
ThomasMichon Apr 7, 2018
f82dcfa
Update snapshot output
ThomasMichon Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/details-header_2018-04-07-01-42.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fix style and alignment issues with DetailsList headers",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "tmichon@microsoft.com"
}
4 changes: 3 additions & 1 deletion packages/office-ui-fabric-react/src/common/_semanticSlots.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ $menuHeaderColor: "[theme:menuHeader, default: #0078d4]";
/* Lists */
$listBackgroundColor: "[theme:listBackground, default: #ffffff]";
$listTextColor: "[theme:listText, default: #333333]";
$listItemHeaderHoveredColor: "[theme:listItemHeaderHovered, default: #f4f4f4]";
$listItemHeaderActivatedColor: "[theme:listItemActivatedHovered, default: #eaeaea]";
$listItemBackgroundHoveredColor: "[theme:listItemBackgroundHovered, default: #f8f8f8]";
$listItemBackgroundCheckedColor: "[theme:listItemBackgroundChecked, default: #eaeaea]";
$listItemBackgroundCheckedHoveredColor: "[theme:listItemBackgroundCheckedHovered, default: #d0d0d0]";
$listItemBackgroundCheckedHoveredColor: "[theme:listItemBackgroundCheckedHovered, default: #d0d0d0]";
23 changes: 15 additions & 8 deletions packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ $isPaddedMargin: 24px;

&:hover {
color: $bodyTextColor;
background: $bodyBackgroundColor;
background: $listItemHeaderHoveredColor;
}

&:active {
background: $listItemBackgroundHoveredColor;
background: $listItemHeaderActivatedColor;
}
}

Expand Down Expand Up @@ -161,16 +161,23 @@ $isPaddedMargin: 24px;
}

.cellTitle {
display: block;
display: inline-flex;
flex-direction: row;
justify-content: flex-start;
align-items: stretch;
box-sizing: border-box;
overflow: hidden;
@include focus-border($position: absolute);
top: 0;
left: 0;
bottom: 0;
right: 0;
max-width: 100%;
@include focus-border($position: auto);
padding: 0 8px;
}

.cellName {
flex: 1 1 auto;
overflow: hidden;
text-overflow: ellipsis;
}

:global(.ms-TooltipHost).checkTooltip {
display: block;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export class DetailsHeader extends BaseComponent<IDetailsHeaderProps, IDetailsHe
className={ css('ms-DetailsHeader-cellTitle', styles.cellTitle) }
data-is-focusable={ column.columnActionsMode !== ColumnActionsMode.disabled }
role={ column.columnActionsMode !== ColumnActionsMode.disabled ? 'button' : undefined }
aria-describedby={ `${this._id}-${column.key}-tooltip` }
aria-describedby={ this.props.onRenderColumnHeaderTooltip ? `${this._id}-${column.key}-tooltip` : undefined }
onContextMenu={ this._onColumnContextMenu.bind(this, column) }
onClick={ this._onColumnClick.bind(this, column) }
aria-haspopup={ column.columnActionsMode === ColumnActionsMode.hasDropdown }
Expand Down
4 changes: 2 additions & 2 deletions ...fice-ui-fabric-react/src/components/DetailsList/__snapshots__/DetailsHeader.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ exports[`DetailsHeader can render 1`] = `
className=""
>
<span
aria-describedby="header0-a-tooltip"
aria-describedby={undefined}
aria-haspopup={false}
aria-label={undefined}
aria-labelledby="header0-a-name "
Expand Down Expand Up @@ -183,7 +183,7 @@ exports[`DetailsHeader can render 1`] = `
className=""
>
<span
aria-describedby="header0-b-tooltip"
aria-describedby={undefined}
aria-haspopup={false}
aria-label={undefined}
aria-labelledby="header0-b-name "
Expand Down
2 changes: 1 addition & 1 deletion ...office-ui-fabric-react/src/components/DetailsList/__snapshots__/DetailsList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ exports[`DetailsList renders List correctly 1`] = `
className=""
>
<span
aria-describedby="header0-key-tooltip"
aria-describedby={undefined}
aria-haspopup={false}
aria-label={undefined}
aria-labelledby="header0-key-name "
Expand Down
1 change: 1 addition & 0 deletions ...ice-ui-fabric-react/src/components/DetailsList/examples/DetailsList.Documents.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export class DetailsListDocumentsExample extends React.Component<any, IDetailsLi
fieldName: 'name',
minWidth: 16,
maxWidth: 16,
onColumnClick: this._onColumnClick,
onRender: (item: IDocument) => {
return (
<img
Expand Down