Skip to content

Tile: exporting an enum. #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 4 commits into from
Apr 10, 2018
Merged

Tile: exporting an enum. #4484

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60e9abe
Exports an enum from Tile.tsx needed for ShimmerTile creation.
Apr 6, 2018
34e9f7e
Change log.
Apr 6, 2018
5a885d9
Exports another const needed for ShimmerPlaceholderTile for values to…
Apr 8, 2018
abac998
Renames a SIZES to TileLayoutSizes.
Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/experiments/v-vibr-TileEnumExport_2018-04-06-22-50.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/experiments",
"comment": "Tile: exporting an enum to use the values in creating a PlaceholderTile in Shimmer component.",
"type": "patch"
}
],
"packageName": "@uifabric/experiments",
"email": "v-vibr@microsoft.com"
}
4 changes: 2 additions & 2 deletions packages/experiments/src/components/Tile/Tile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const SignalStyles: any = SignalStylesModule;
const CheckStyles: any = CheckStylesModule;
// tslint:enable:no-any

const enum TileLayoutValues {
export const enum TileLayoutValues {
nameplatePadding = 12,
largeNameplateNameHeight = 15,
smallNameplateNameHeight = 12,
Expand All @@ -29,7 +29,7 @@ export interface ITileState {
isModal?: boolean;
}

const SIZES: {
export const SIZES: {

@dzearing dzearing Apr 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of exporting "SIZES", can you rename this to something specific to tile, and use TitleCasing?

TileLayoutSizes would be reasonable.

@dzearing dzearing Apr 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think of it like this: When you import {} from '@uifabric/experiments'; the intellisense will suggest importing SIZES. Does that make sense to the caller?

@Vitalius1 Vitalius1 Apr 9, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for the feedback. I guess if you are putting it in the context of intellisense when importing makes total sense.

[P in TileSize]: {
nameplatePadding: number;
nameplateNameHeight: number;
Expand Down