Skip to content

ScrollablePane: Fix StickyAbove/StickyBelow extending past scrollablePane width. Fix DetailsList virtualization rendering #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leddie24 wants to merge 2 commits into from
Closed

ScrollablePane: Fix StickyAbove/StickyBelow extending past scrollablePane width. Fix DetailsList virtualization rendering #4467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f556ae
Set data-is-scrollable on root of ScrollablePane. Set max-width to i…
edwlmsft Apr 4, 2018
6fe7ee3
Add rush change file
edwlmsft Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/edwl-scrollablePaneFixWidth_2018-04-04-23-40.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ScrollablePane: Fix DetailsList rows not rendering. Add maxWidth to StickyAbove/StickyBelow",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/ScrollablePane/ScrollablePane.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,11 @@ export class ScrollablePaneBase extends BaseComponent<IScrollablePaneProps, {}>
{ ...getNativeProps(this.props, divProperties) }
ref={ this._root }
className={ classNames.root }
data-is-scrollable={ true }
>
<div ref={ this._stickyAboveRef } className={ classNames.stickyAbove } />
<div ref={ this._stickyBelowRef } className={ classNames.stickyBelow } />
<div data-is-scrollable={ true }>
<div>
{ this.props.children }
</div>
</div>
Expand Down
32 changes: 0 additions & 32 deletions packages/office-ui-fabric-react/src/components/ScrollablePane/ScrollablePane.scss
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/ScrollablePane/ScrollablePane.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const getStyles = (
position: 'absolute',
pointerEvents: 'auto',
width: '100%',
maxWidth: 'inherit',
zIndex: 1
};

Expand Down