Skip to content

ScrollablePane: Fix StickyAbove/StickyBelow extending past scrollablePane width. Fix DetailsList virtualization rendering #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leddie24 wants to merge 2 commits into from
Closed

ScrollablePane: Fix StickyAbove/StickyBelow extending past scrollablePane width. Fix DetailsList virtualization rendering #4467

leddie24 wants to merge 2 commits into from

Conversation

@leddie24
Copy link
Collaborator

@leddie24 leddie24 commented Apr 4, 2018 •
edited
Loading

Pull request checklist

Description of changes

  • Sets a maxWidth to inherit from its parent max width to not extend past the ScrollablePane bounds.
  • Revert change in Fix issues in scrollable pane #4055 that adds data-is-scrollable=true to an inner div of scrollablePane that breaks DetailsList row virtualization.
  • Remove unused scss file

Focus areas to test

(optional)

@leddie24 leddie24 closed this Apr 9, 2018
@leddie24
Copy link
Collaborator Author

leddie24 commented Apr 9, 2018

Closed, New PR is at #4491

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MaxLustig MaxLustig Awaiting requested review from MaxLustig

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ScrollablePane with DetailsList does not show (virtualized) items

2 participants

@leddie24 @edwlmsft