-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add DocumentCardLogo and DocumentCardStatus for supporting conversation activity card #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6079116
Add DocumentCardLogo
inateeg f87d0de
add changes file
inateeg bf5004c
add changes file
inateeg 5327716
update
inateeg bc46ee4
update on title to support secondary title used as text preview
inateeg 8378fba
update
inateeg 3436091
update
inateeg cc16494
remove focusZone fix that is not relevant to this change
inateeg b42aac0
removed unintentional changed files
inateeg 23969cb
update
inateeg 84f60c8
change file
inateeg 6011685
update
inateeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/inateeg-0302card_2018-03-16-06-06.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Add DocumentCardLogo and DoucmentCardStatus for Conversation card", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "inateeg@microsoft.com" | ||
| } | ||
Empty file.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "dependencies": { | ||
| "npm": "3.10.9" | ||
| }, | ||
| "description": "Temporary file generated by the Rush tool", | ||
| "name": "npm-local-install", | ||
| "private": true, | ||
| "version": "0.0.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "localLinks": { | ||
| "todo-app": [ | ||
| "office-ui-fabric-react" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "localLinks": { | ||
| "fabric-website": [ | ||
| "@uifabric/utilities", | ||
| "office-ui-fabric-react" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i'm confused why these files are in the PR... |
||
| ], | ||
| "office-ui-fabric-react": [ | ||
| "@uifabric/utilities" | ||
| ], | ||
| "todo-app": [ | ||
| "office-ui-fabric-react" | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/office-ui-fabric-react/src/components/DocumentCard/DocumentCardLogo.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import * as React from 'react'; | ||
| import { BaseComponent, css } from '../../Utilities'; | ||
| import { IDocumentCardLogoProps } from './DocumentCard.types'; | ||
| import { Icon } from '../../Icon'; | ||
| import * as stylesImport from './DocumentCard.scss'; | ||
| const styles: any = stylesImport; | ||
|
|
||
| export class DocumentCardLogo extends BaseComponent<IDocumentCardLogoProps, any> { | ||
| public render() { | ||
| const { logoIcon } = this.props; | ||
|
|
||
| return ( | ||
| <div className={ css('ms-DocumentCardLogo', styles.logo) }> | ||
| <Icon iconName={ logoIcon } /> | ||
| </div> | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
packages/office-ui-fabric-react/src/components/DocumentCard/DocumentCardStatus.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* tslint:disable:no-unused-variable */ | ||
| import * as React from 'react'; | ||
| /* tslint:enable:no-unused-variable */ | ||
|
|
||
| import { | ||
| BaseComponent, | ||
| autobind, | ||
| css | ||
| } from '../../Utilities'; | ||
| import { IDocumentCardStatusProps } from './DocumentCard.types'; | ||
| import * as stylesImport from './DocumentCard.scss'; | ||
| import { Icon } from '../../Icon'; | ||
| const styles: any = stylesImport; | ||
|
|
||
| export class DocumentCardStatus extends BaseComponent<IDocumentCardStatusProps, any> { | ||
| constructor(props: IDocumentCardStatusProps) { | ||
| super(props); | ||
| } | ||
|
|
||
| public render() { | ||
| const { statusIcon, status } = this.props; | ||
| const iconProps = { | ||
| iconName: statusIcon, styles: { | ||
| root: { padding: '8px' } | ||
| } | ||
| }; | ||
| return ( | ||
| <div className={ css('ms-DocumentCardStatus', styles.status) }> | ||
| { statusIcon && <Icon { ...iconProps } /> } | ||
| { status } | ||
| </div> | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor