Skip to content

DetailsList: scrollbars show up unnecessarily on IE11 #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aditima merged 6 commits into from
Mar 16, 2018
Merged

DetailsList: scrollbars show up unnecessarily on IE11 #4291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
290e1b3
Fix issue 3608: DetailsList horizontal scroll
aditima Mar 2, 2018
be96ee9
add change file
aditima Mar 2, 2018
9c2cd49
DetailsList: scrollbars show up unnecessarily on IE11
aditima Mar 15, 2018
304c481
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
aditima Mar 15, 2018
3f05221
add change file
aditima Mar 15, 2018
479b9a8
remove left-over change file
aditima Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/aditima-ie11-detailslist-scroll_2018-03-15-23-43.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DetailsList: scrollbars show up unnecessarily on IE11",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "aditima@microsoft.com"
}
1 change: 0 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsList.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ $detailsList-text-color: $listTextColor;

.focusZone {
display: inline-block;
vertical-align: top;
Copy link
Copy Markdown
Member

@dzearing dzearing Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could have potential side effects on some browsers. I think it could be ok, @ThomasMichon any concerns?

Copy link
Copy Markdown
Contributor Author

@aditima aditima Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke to David on phone. This is certainly a browser bug, the heights of the content and the container are exactly same, but IE doesn't line them up correctly unless I get rid of this vertical align. I actually feel a little less bad about this because it's only changing the DetailsList styles. Tested on Chrome and works for the basic cases and the demo page.

I'll go ahead and merge this.

min-width: 100%;
min-height: 1px;
}
Expand Down