Skip to content

Nav component sets aria-label on <nav> element #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 1 commit into from
Mar 16, 2018
Merged

Nav component sets aria-label on <nav> element #4266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/nav-element-aria-label_2018-03-14-01-34.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Nav component sets aria-label on nested element with role=navigation",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "shiran.pasternak@microsoft.com"
}
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/Nav/Nav.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export class NavBase extends BaseComponent<INavProps, INavState> implements INav
<nav
role='navigation'
className={ classNames.root }
aria-label={ this.props.ariaLabel }
>
{ groupElements }
</nav>
Expand Down Expand Up @@ -218,7 +219,7 @@ export class NavBase extends BaseComponent<INavProps, INavState> implements INav
const classNames = getClassNames(getStyles!, { theme: theme!, groups });

return (
<ul role='list' aria-label={ this.props.ariaLabel } className={ classNames.navItems }>
<ul role='list' className={ classNames.navItems }>
{ linkElements }
</ul>
);
Expand Down
10 changes: 10 additions & 0 deletions packages/office-ui-fabric-react/src/components/Nav/Nav.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,14 @@ describe('Nav', () => {
link.simulate('click');
expect(handler.mock.calls.length).toBe(1);
});

it('sets ARIA label on the nav element', () => {
const label = 'The navigation label';
const nav = mount<NavBase>(
<Nav
ariaLabel={ label }
groups={ [] }
/>);
expect(nav.find('[role="navigation"]').prop('aria-label')).toEqual(label);
});
});
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ exports[`Nav renders Nav correctly 1`] = `
role="presentation"
>
<nav
aria-label={undefined}
className=
ms-Nav
{
Expand Down Expand Up @@ -40,7 +41,6 @@ exports[`Nav renders Nav correctly 1`] = `
}
>
<ul
aria-label={undefined}
className=
ms-Nav-navItems
{
Expand Down